vndangkhoa/kv-music
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: EQ toggle not disabling audio filters when turned off

Browse source 
setEQMode() was unconditionally setting isEQEnabled = true, overriding
the user's toggle state. Now respects equalizerSettings.isEnabled().
Also fixed the toggle handler to properly disable the graphic EQ chain
in legacy mode.
This commit is contained in:
tryptz 2026-04-05 00:46:42 +00:00 committed by edideaur
parent d09e3aa72a
commit bd70b81a39
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
js/settings.js
View file

@ -3414,11 +3414,11 @@ export async function initializeSettings(scrobbler, player, api, ui) {
if (legacySection) legacySection.style.display = ''; if (legacySection) legacySection.style.display = '';
// Disable parametric EQ entirely - only graphic EQ active to save resources // Disable parametric EQ entirely - only graphic EQ active to save resources
audioContextManager.isEQEnabled = false; audioContextManager.isEQEnabled = false;
audioContextManager.toggleGraphicEQ(true); audioContextManager.toggleGraphicEQ(equalizerSettings.isEnabled());
equalizerSettings.setGraphicEqEnabled(true); equalizerSettings.setGraphicEqEnabled(true);
} else { } else {
// Disable graphic EQ entirely - only parametric EQ active to save resources // Disable graphic EQ entirely - only parametric EQ active to save resources
audioContextManager.isEQEnabled = true; audioContextManager.isEQEnabled = equalizerSettings.isEnabled();
audioContextManager.toggleGraphicEQ(false); audioContextManager.toggleGraphicEQ(false);
equalizerSettings.setGraphicEqEnabled(false); equalizerSettings.setGraphicEqEnabled(false);
} }
@ -4690,7 +4690,15 @@ export async function initializeSettings(scrobbler, player, api, ui) {
equalizerSettings.setEnabled(enabled); equalizerSettings.setEnabled(enabled);
updateEQContainerVisibility(enabled); updateEQContainerVisibility(enabled);
audioContextManager.toggleEQ(enabled); if (currentMode === 'legacy') {
// Legacy mode uses graphic EQ chain
audioContextManager.isEQEnabled = false;
audioContextManager.toggleGraphicEQ(enabled);
} else {
// AutoEQ/Parametric/Speaker modes use parametric EQ chain
audioContextManager.toggleEQ(enabled);
audioContextManager.toggleGraphicEQ(false);
}
}); });
} }