From bd70b81a3904aeeb3b7fafcef5400831daa21cc5 Mon Sep 17 00:00:00 2001
From: tryptz <xboxps3456felix@gmail.com>
Date: Sun, 5 Apr 2026 00:46:42 +0000
Subject: [PATCH] fix: EQ toggle not disabling audio filters when turned off

setEQMode() was unconditionally setting isEQEnabled = true, overriding
the user's toggle state. Now respects equalizerSettings.isEnabled().
Also fixed the toggle handler to properly disable the graphic EQ chain
in legacy mode.
---
 js/settings.js | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/js/settings.js b/js/settings.js
index 72cd279..5cd33c1 100644
--- a/js/settings.js
+++ b/js/settings.js
@@ -3414,11 +3414,11 @@ export async function initializeSettings(scrobbler, player, api, ui) {
             if (legacySection) legacySection.style.display = '';
             // Disable parametric EQ entirely - only graphic EQ active to save resources
             audioContextManager.isEQEnabled = false;
-            audioContextManager.toggleGraphicEQ(true);
+            audioContextManager.toggleGraphicEQ(equalizerSettings.isEnabled());
             equalizerSettings.setGraphicEqEnabled(true);
         } else {
             // Disable graphic EQ entirely - only parametric EQ active to save resources
-            audioContextManager.isEQEnabled = true;
+            audioContextManager.isEQEnabled = equalizerSettings.isEnabled();
             audioContextManager.toggleGraphicEQ(false);
             equalizerSettings.setGraphicEqEnabled(false);
         }
@@ -4690,7 +4690,15 @@ export async function initializeSettings(scrobbler, player, api, ui) {
             equalizerSettings.setEnabled(enabled);
             updateEQContainerVisibility(enabled);
 
-            audioContextManager.toggleEQ(enabled);
+            if (currentMode === 'legacy') {
+                // Legacy mode uses graphic EQ chain
+                audioContextManager.isEQEnabled = false;
+                audioContextManager.toggleGraphicEQ(enabled);
+            } else {
+                // AutoEQ/Parametric/Speaker modes use parametric EQ chain
+                audioContextManager.toggleEQ(enabled);
+                audioContextManager.toggleGraphicEQ(false);
+            }
         });
     }