vndangkhoa/kv-music
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: position EQ nodes at individual band gain, not composite sum

Browse source
This commit is contained in:
tryptz 2026-04-07 09:01:10 -04:00 committed by edideaur
parent ab23c3e64e
commit 88b01570f5
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
js/settings.js
View file

@ -2253,16 +2253,17 @@ export async function initializeSettings(scrobbler, player, api, ui) {
const x = gx(band.freq); const x = gx(band.freq);
// In parametric mode: node Y = band's individual response at its freq (basically its gain) // In parametric mode: node Y = band's individual response at its freq (basically its gain)
// In AutoEQ mode: node Y = corrected curve value at band freq (shifted) // In AutoEQ mode: node Y = corrected curve value at band freq (shifted)
let nodeGain; let nodeGain, sumGain;
if (isParametricMode) { if (isParametricMode) {
// Sum all bands' response at this frequency // Node sits at individual band gain; sum is for tooltip only
let totalGain = 0; nodeGain = band.gain;
sumGain = 0;
for (const b of activeBands) { for (const b of activeBands) {
if (b.enabled) totalGain += calculateBiquadResponse(band.freq, b, sampleRate); if (b.enabled) sumGain += calculateBiquadResponse(band.freq, b, sampleRate);
} }
nodeGain = totalGain;
} else { } else {
nodeGain = interpolate(band.freq, autoeqCorrectedCurve) + graphShift; nodeGain = interpolate(band.freq, autoeqCorrectedCurve) + graphShift;
sumGain = nodeGain;
} }
const y = gy(nodeGain); const y = gy(nodeGain);
@ -2331,7 +2332,7 @@ export async function initializeSettings(scrobbler, player, api, ui) {
ctx.font = 'bold 11px system-ui, sans-serif'; ctx.font = 'bold 11px system-ui, sans-serif';
const chLabel = bandChannel !== 'stereo' ? ` [${bandChannel.toUpperCase()}]` : ''; const chLabel = bandChannel !== 'stereo' ? ` [${bandChannel.toUpperCase()}]` : '';
const line1 = `${Math.round(band.freq)} Hz ${band.gain > 0 ? '+' : ''}${band.gain.toFixed(1)} dB Q${band.q.toFixed(2)}${chLabel}`; const line1 = `${Math.round(band.freq)} Hz ${band.gain > 0 ? '+' : ''}${band.gain.toFixed(1)} dB Q${band.q.toFixed(2)}${chLabel}`;
const line2 = `Sum: ${nodeGain > 0 ? '+' : ''}${nodeGain.toFixed(1)} dB`; const line2 = `Sum: ${sumGain > 0 ? '+' : ''}${sumGain.toFixed(1)} dB`;
const tw1 = ctx.measureText(line1).width; const tw1 = ctx.measureText(line1).width;
const tw2 = ctx.measureText(line2).width; const tw2 = ctx.measureText(line2).width;
const tw = Math.max(tw1, tw2) + 12; const tw = Math.max(tw1, tw2) + 12;
@ -2445,10 +2446,7 @@ export async function initializeSettings(scrobbler, player, api, ui) {
const x = padLeft + freqToX(band.freq, w); const x = padLeft + freqToX(band.freq, w);
let nodeGain; let nodeGain;
if (isParam) { if (isParam) {
nodeGain = 0; nodeGain = band.gain;
for (const b of activeBands) {
if (b.enabled) nodeGain += calculateBiquadResponse(band.freq, b, sampleRate);
}
} else { } else {
nodeGain = interpolate(band.freq, autoeqCorrectedCurve) + graphShift; nodeGain = interpolate(band.freq, autoeqCorrectedCurve) + graphShift;
} }