mirror of
https://github.com/zed-industries/zed.git
synced 2026-06-01 03:14:56 +07:00
6bca2136a1
## Summary While profiling agent sessions that make a lot of `edit_file` operations, I noticed the LSP `textDocument/didChange` handler firing excessively. Looking into this, I found out that the streaming edit pipeline was applying each `CharOperation` from `StreamingDiff` as its own `buffer.edit` transaction, and every transaction emits a `BufferEvent::Edited` event. Each event can trigger several other expensive events depending on whether the buffer is being rendered in an editor or is registered with a language. For example, there are `didChange` LSP events, the editor's on edit work (matching brackets, bracket colorization, code actions, outline), and more. A single `edit_file` could trigger hundreds of these at the higher end in a single synchronous app update, which would block the foreground thread for a bit and cause Zed to drop frames. I fixed this by collecting all of a chunk's `CharOperation`s and applying them in one `buffer.edit` call, so only a single `BufferEvent::Edited` event gets emitted. This is safe because operations are non overlapping by design of streaming diff (the edit cursor only advances). ## Why this wasn't caught earlier The cost only fully appears when a buffer is both registered with a language server and rendered in an editor. Without that, most of the per transaction observers never run, so the existing `edit_file_tool` benchmark (which ran the tool against a bare buffer) didn't surface it. I reworked the benchmark to open the edited buffer in an editor view, register a fake language server with per edit diagnostics, and lay out a frame, so it exercises the same cascade as the real editor. I also added a larger fixture. ## Results Measured with the `release-fast` profile on the reworked benchmark: | Fixture | Initial file | Before | After | Improvement | | --- | --- | --- | --- | --- | | `tiny_function_rewrite` | 1.4 KB | 31.1 ms | 12.1 ms | −61% | | `small_function_rewrite` | 3.0 KB | 42.4 ms | 19.3 ms | −55% | | `medium_many_small_changes` | 4.6 KB | 309.2 ms | 151.5 ms | −51% | | `medium_insertions` | 4.6 KB | 171.8 ms | 126.1 ms | −27% | | `large_multi_edit` | 44 KB | 9,549 ms | 919 ms | −90% | Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the UI/UX checklist - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Improved agent's edit file tool performance
116 lines
3.2 KiB
TOML
116 lines
3.2 KiB
TOML
[package]
|
|
name = "agent"
|
|
version = "0.1.0"
|
|
edition.workspace = true
|
|
publish.workspace = true
|
|
license = "GPL-3.0-or-later"
|
|
|
|
[lib]
|
|
path = "src/agent.rs"
|
|
|
|
[features]
|
|
test-support = ["db/test-support"]
|
|
unit-eval = []
|
|
e2e = []
|
|
|
|
[lints]
|
|
workspace = true
|
|
|
|
[dependencies]
|
|
acp_thread.workspace = true
|
|
action_log.workspace = true
|
|
async-channel.workspace = true
|
|
agent-client-protocol.workspace = true
|
|
agent_servers.workspace = true
|
|
agent_settings.workspace = true
|
|
agent_skills.workspace = true
|
|
anyhow.workspace = true
|
|
chrono.workspace = true
|
|
client.workspace = true
|
|
cloud_api_types.workspace = true
|
|
cloud_llm_client.workspace = true
|
|
collections.workspace = true
|
|
context_server.workspace = true
|
|
db.workspace = true
|
|
feature_flags.workspace = true
|
|
fs.workspace = true
|
|
futures.workspace = true
|
|
git.workspace = true
|
|
gpui.workspace = true
|
|
handlebars = { workspace = true, features = ["rust-embed"] }
|
|
heck.workspace = true
|
|
html_to_markdown.workspace = true
|
|
http_client.workspace = true
|
|
indoc.workspace = true
|
|
itertools.workspace = true
|
|
language.workspace = true
|
|
language_model.workspace = true
|
|
language_models.workspace = true
|
|
log.workspace = true
|
|
parking_lot.workspace = true
|
|
paths.workspace = true
|
|
project.workspace = true
|
|
prompt_store.workspace = true
|
|
quick-xml.workspace = true
|
|
regex.workspace = true
|
|
rust-embed.workspace = true
|
|
schemars.workspace = true
|
|
serde.workspace = true
|
|
serde_json.workspace = true
|
|
settings.workspace = true
|
|
shell_command_parser.workspace = true
|
|
smallvec.workspace = true
|
|
sqlez.workspace = true
|
|
streaming_diff.workspace = true
|
|
strsim.workspace = true
|
|
task.workspace = true
|
|
telemetry.workspace = true
|
|
tempfile.workspace = true
|
|
text.workspace = true
|
|
thiserror.workspace = true
|
|
ui.workspace = true
|
|
url.workspace = true
|
|
util.workspace = true
|
|
uuid.workspace = true
|
|
watch.workspace = true
|
|
web_search.workspace = true
|
|
zed_env_vars.workspace = true
|
|
zstd.workspace = true
|
|
|
|
[dev-dependencies]
|
|
assets.workspace = true
|
|
async-io.workspace = true
|
|
agent_servers = { workspace = true, "features" = ["test-support"] }
|
|
client = { workspace = true, "features" = ["test-support"] }
|
|
clock = { workspace = true, "features" = ["test-support"] }
|
|
context_server = { workspace = true, "features" = ["test-support"] }
|
|
criterion.workspace = true
|
|
ctor.workspace = true
|
|
db = { workspace = true, "features" = ["test-support"] }
|
|
editor = { workspace = true, "features" = ["test-support"] }
|
|
env_logger.workspace = true
|
|
eval_utils.workspace = true
|
|
fs = { workspace = true, "features" = ["test-support"] }
|
|
git = { workspace = true, "features" = ["test-support"] }
|
|
gpui = { workspace = true, "features" = ["test-support"] }
|
|
gpui_tokio.workspace = true
|
|
language = { workspace = true, "features" = ["test-support"] }
|
|
language_model = { workspace = true, "features" = ["test-support"] }
|
|
lsp = { workspace = true, "features" = ["test-support"] }
|
|
pretty_assertions.workspace = true
|
|
project = { workspace = true, "features" = ["test-support"] }
|
|
rand.workspace = true
|
|
reqwest_client.workspace = true
|
|
settings = { workspace = true, "features" = ["test-support"] }
|
|
|
|
theme = { workspace = true, "features" = ["test-support"] }
|
|
theme_settings.workspace = true
|
|
|
|
unindent = { workspace = true }
|
|
|
|
zlog.workspace = true
|
|
|
|
[[bench]]
|
|
name = "edit_file_tool"
|
|
harness = false
|
|
required-features = ["test-support"]
|