mirror of
https://github.com/zed-industries/zed.git
synced 2026-06-01 03:14:56 +07:00
278e81b7db
## Context Follow-up to #51964. The previous fix (stripping HTML comments) still had a false positive: the `## How to Review` heading itself matched the `how to review` alternative in the regex. Every PR using the template would trigger the "guided tour detected" message. Replace the regex with structural detection: extract the "How to Review" section, strip template placeholders, and check if the author actually wrote content there. Also softens the confirmation message to "appears to include guidance." ## How to Review - Single file: `.github/workflows/pr-size-check.yml`, lines 147-154 - The `rawBody.match(...)` extracts content between `## How to Review` and the next `##` heading - Confirmed: PR #51957's body returns `false`, a PR with actual content returns `true` ## Self-Review Checklist - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A |
||
|---|---|---|
| .. | ||
| add_commented_closed_issue_to_project.yml | ||
| after_release.yml | ||
| assign-reviewers.yml | ||
| autofix_pr.yml | ||
| background_agent_mvp.yml | ||
| bump_collab_staging.yml | ||
| bump_patch_version.yml | ||
| catch_blank_issues.yml | ||
| cherry_pick.yml | ||
| comment_on_potential_duplicate_issues.yml | ||
| community_champion_auto_labeler.yml | ||
| community_close_stale_issues.yml | ||
| community_update_all_top_ranking_issues.yml | ||
| community_update_weekly_top_ranking_issues.yml | ||
| compare_perf.yml | ||
| congrats.yml | ||
| danger.yml | ||
| deploy_cloudflare.yml | ||
| deploy_collab.yml | ||
| docs_suggestions.yml | ||
| extension_auto_bump.yml | ||
| extension_bump.yml | ||
| extension_tests.yml | ||
| extension_workflow_rollout.yml | ||
| good_first_issue_notifier.yml | ||
| hotfix-review-monitor.yml | ||
| pr-size-check.yml | ||
| pr_labeler.yml | ||
| publish_extension_cli.yml | ||
| randomized_tests.yml | ||
| release.yml | ||
| release_nightly.yml | ||
| run_agent_evals.yml | ||
| run_bundling.yml | ||
| run_cron_unit_evals.yml | ||
| run_tests.yml | ||
| run_unit_evals.yml | ||
| slack_notify_first_responders.yml | ||
| stale-pr-reminder.yml | ||
| track_duplicate_bot_effectiveness.yml | ||
| update_duplicate_magnets.yml | ||