vndangkhoa/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2026-06-01 03:14:56 +07:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

ui_input: Only render number field border on focus (#46165)

Browse source 
The `NumberField.render` method was always rendering a `border_1` for
the number input, even when not focused. Even though it was using
`cx.theme().colors().border_transparent`, some themes don't have this
value set to a fully transparent color so it ends up looking a little
bit weird.

As such, this commit updates the way the border is rendered, to ensure
it's actually only rendered, i.e., the `border_1` method is only called,
when the field is actually focused.

Release Notes:

- Improved rendering of border on number field's input to ensure it's
only rendered when the field is focused
This commit is contained in:
Dino 2026-01-07 10:52:51 +00:00 committed by GitHub
parent 9e9269b521
commit f845893238
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
crates/ui_input/src/number_field.rs
View file

@ -687,11 +687,11 @@ impl<T: NumberFieldType> RenderOnce for NumberField<T> {
h_flex()
.flex_1()
.h_full()
.track_focus(&focus_handle)
.border_1()
.border_color(cx.theme().colors().border_transparent)
.when(is_focused, |this| {
this.border_color(cx.theme().colors().border_focused)
this.border_1()
.border_color(cx.theme().colors().border_focused)
})
.child(editor)
.on_action::<menu::Confirm>({