vndangkhoa/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2026-05-31 19:05:00 +07:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Fix terminal path click failing when path is prefixed with '0:' (#50663)

Browse source 
The path hyperlink regex's middle-char pattern
[[:(][^0-9()]](cci:2://file:///d:/zed/crates/fs/src/fs.rs:89:0-157:1)
allowed colon+space because space was not in the exclusion set. This
caused `0: foo/bar.txt` to be matched as a single path instead of just
`foo/bar.txt`.

Fix: add space to the exclusion class: [[:(][^0-9()\\
]](cci:2://file:///d:/zed/crates/fs/src/fs.rs:89:0-157:1)

Closes #50531

- [x] Added a solid test coverage and/or screenshots from doing manual
testing
- [x] Done a self-review taking into account security and performance
aspects
- [ ] Aligned any UI changes with the [UI
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
(N/A)

Release Notes:

- Fixed terminal Ctrl-click path detection failing when path is preceded
by a prefix like `0:` (#50531)
This commit is contained in:
xcb3d 2026-03-04 23:42:14 +07:00 committed by GitHub
parent 68cb60afdd
commit 83b05f1cbb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
assets/settings/default.json
View file

@ -1831,8 +1831,8 @@
" (",
" # multi-char path: first char (not opening delimiter, space, or box drawing char)",
" [^({\\[<\"'`\\ \\u2500-\\u257F]",
" # middle chars: non-space, and colon/paren only if not followed by digit/paren",
" ([^\\ :(]|[:(][^0-9()])*",
" # middle chars: non-space, and colon/paren only if not followed by digit/paren/space",
" ([^\\ :(]|[:(][^0-9()\\ ])*",
" # last char: not closing delimiter or colon",
" [^()}\\]>\"'`.,;:\\ ]",
" |",

12
crates/terminal/src/terminal_hyperlinks.rs
View file

@ -905,6 +905,18 @@ mod tests {
);
}
#[test]
// <https://github.com/zed-industries/zed/issues/50531>
fn issue_50531() {
// Paths preceded by "N:" prefix (e.g. grep output line numbers)
// should still be clickable
test_path!("0: ‹«foo/👉bar.txt»›");
test_path!("0: ‹«👉foo/bar.txt»›");
test_path!("42: ‹«👉foo/bar.txt»›");
test_path!("1: ‹«/👉test/cool.rs»›");
test_path!("1: ‹«/👉test/cool.rs»:«4»:«2»›");
}
#[test]
// <https://github.com/zed-industries/zed/issues/46795>
fn issue_46795() {