vndangkhoa/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2026-06-01 03:14:56 +07:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

signature_help: Fix crash when typing CJK in debug mode (#45785)

Browse source 
in release mode: found many log error as `ERROR [rope::chunk] byte index
48 is not a char boundary; it is inside '，' (bytes 46..49)`

This is easy testing,
- enable signature help
- typing any CJK character
- crash in debug mode

Release Notes:

- N/A
This commit is contained in:
CharlesChen0823 2026-01-07 00:28:27 +08:00 committed by GitHub
parent 4f59ec05e2
commit 44b6995ac6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
crates/editor/src/signature_help.rs
View file

@ -94,11 +94,16 @@ impl Editor {
}
let buffer_snapshot = self.buffer().read(cx).snapshot(cx);
let bracket_range = |position: MultiBufferOffset| match (position, position + 1usize) {
(MultiBufferOffset(0), b) if b <= buffer_snapshot.len() => MultiBufferOffset(0)..b,
(MultiBufferOffset(0), b) => MultiBufferOffset(0)..b - 1,
(a, b) if b <= buffer_snapshot.len() => a - 1..b,
(a, b) => a - 1..b - 1,
let bracket_range = |position: MultiBufferOffset| {
let range = match (position, position + 1usize) {
(MultiBufferOffset(0), b) if b <= buffer_snapshot.len() => MultiBufferOffset(0)..b,
(MultiBufferOffset(0), b) => MultiBufferOffset(0)..b - 1,
(a, b) if b <= buffer_snapshot.len() => a - 1..b,
(a, b) => a - 1..b - 1,
};
let start = buffer_snapshot.clip_offset(range.start, text::Bias::Left);
let end = buffer_snapshot.clip_offset(range.end, text::Bias::Right);
start..end
};
let not_quote_like_brackets =
|buffer: &BufferSnapshot, start: Range<BufferOffset>, end: Range<BufferOffset>| {