mirror of
https://github.com/ZSeven-W/openpencil.git
synced 2026-06-01 03:14:29 +07:00
904c033290
* Stabilize synced main for AI handoff, drag nesting, and Electron dev (#104) * docs(readme): update cover screenshot * fix: stabilize electron dev sync and codex env passthrough * Preserve nested frame behavior during drag reparenting Reparenting across containers used raw local coordinates and root-only clipping assumptions, which made nodes jump visually and caused dragged frames to lose clip/corner semantics after nesting. This adapts the drag-reparent fix to the current upstream store architecture, keeps frame/shape nodes from auto-detaching on canvas drags, and promotes formerly root-only frame clipping to explicit clipContent when nested. Constraint: Latest upstream workspace checkout is incomplete locally (missing workspaces/deps), so full upstream verification could not be rerun in this environment Rejected: Keep using raw local x/y during parent changes | fails for auto-layout/padding-rendered positions Rejected: Make all nested frames clip unconditionally | would change non-clipping containers Confidence: medium Scope-risk: moderate Reversibility: clean Directive: Preserve visual-position conversion through rendered coordinates when parent changes; local coordinates alone are insufficient once layout participates Not-tested: Fresh full workspace typecheck/test/build on latest upstream checkout (blocked by missing workspace/dependency setup in this local clone) * Keep AI codegen requests bounded while exporting asset bundles The AI codegen pipeline needed two stability fixes: exported design images had to flow through chunk/assembly prompts as reusable asset hints, and oversized chat payloads needed a local guard before hitting provider limits. This commit wires asset extraction into the planning pipeline, threads exported asset paths into prompt assembly, and rejects obviously overlarge chat requests with an actionable client-side error. Constraint: This branch is split out from a larger local fix stack, so only codegen/prompt/context files are included here Constraint: Provider request limits are approximate locally, so the payload guard must be conservative rather than exact Rejected: Inline base64 assets directly into prompts | explodes request size and repeats the same payload per chunk Rejected: Let provider errors handle oversized payloads | too slow and opaque for users Confidence: high Scope-risk: moderate Reversibility: clean Directive: Keep asset references flowing as stable ./assets paths and enforce payload limits before fetch to avoid silent request bloat Tested: bun x tsc -p apps/web/tsconfig.json --noEmit; cd apps/web && bun --bun vitest run src/services/ai/__tests__/context-optimizer.test.ts src/services/ai/__tests__/codegen-assets.test.ts src/services/ai/__tests__/structure-bundle.test.ts; bun run build Not-tested: Manual end-to-end AI generation with live providers * Explain sanitized design views instead of leaving AI to guess The sanitized structure bundle already stabilized asset paths, but it still exposed low-level image/layout/component fields that models had to interpret on their own. This change adds explicit consumer-view enrichment for fills, layout, text, variables, themes, and component semantics, carries original image size through the Figma import path, and augments sanitized bundles with summary/highlight guidance for downstream AI consumers. Constraint: This branch is intentionally stacked on the asset-bundle PR because it extends the sanitized/codegen asset pipeline rather than replacing it Constraint: Figma import data is not always complete, so original image size must be preserved when present and inferred only as a fallback downstream Rejected: Keep sanitized.json as a pure field-level dump | still leaves AI to misread transforms, layout, and component relationships Rejected: Put all explain text directly in asset extraction helpers | mixes resource stabilization with semantic enrichment responsibilities Confidence: high Scope-risk: moderate Reversibility: clean Directive: Treat consumer-view enrichment as a distinct layer on top of stable asset extraction; future AI-facing semantics should land there instead of leaking into unrelated pipeline code Tested: bun x tsc -p apps/web/tsconfig.json --noEmit; cd apps/web && bun --bun vitest run src/services/ai/__tests__/consumer-view-enrichment.test.ts src/services/ai/__tests__/codegen-assets.test.ts src/services/ai/__tests__/structure-bundle.test.ts ../../packages/pen-figma/src/figma-fill-mapper.test.ts; bun run build Not-tested: Manual prompt-to-code generation quality with live provider responses * Restore code-panel bundle exports for AI handoff flows The code generation backend still produced asset manifests and AI structure bundles, but the code panel UI no longer exposed those export paths after later sync work. This commit reconnects the panel to bundle export actions, restores ZIP download behavior when generated code includes exported assets, and locks the affordances with focused panel tests. Constraint: Other local fixes are still in progress in the working tree, so this commit is intentionally limited to the code-panel export surface Rejected: Rebuild export support in a separate panel | users expect the export actions to remain where generation results are shown Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep code-panel UI aligned with codegen asset/bundle backends whenever generation result shape changes Tested: cd apps/web && bun --bun vitest run src/components/panels/code-panel.test.tsx src/services/ai/__tests__/codegen-assets.test.ts src/services/ai/__tests__/structure-bundle.test.ts; bun run build Not-tested: Manual click-through of AI Bundle and Download ZIP in the desktop/web UI * Unblock electron dev startup in the incomplete local workspace The local workspace was failing before the app could even start: the skills plugin hard-required js-yaml from a node_modules layout that was not present, Vite dev under Bun hit Nitro NodeResponse incompatibilities, and the web tsconfig was missing path mappings for local packages. This commit removes the unnecessary js-yaml dependency from the skills loader, runs Vite under Node for dev startup, hardens readiness probing with socket checks, and points TypeScript/Vite at the in-repo package sources. Constraint: The current local clone has incomplete hoisted/workspace installation state, so dev startup must not depend on root package links being perfectly present Constraint: Bun + Nitro dev currently mis-handle NodeResponse in this environment, so the safest startup path is Node-hosted Vite Rejected: Keep js-yaml and require everyone to fix local hoisting first | still leaves electron:dev broken in the current environment Rejected: Continue running Vite dev through Bun | reproduces the NodeResponse/Parse Error failure on /api and /editor requests Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep the dev launcher biased toward resilient local startup, even when the workspace install shape is imperfect Tested: bun -e import('./packages/pen-ai-skills/vite-plugin-skills.ts').then(() => console.log('SKILL_PLUGIN_IMPORT_OK')); bun electron:dev verified Vite ready, MCP/Electron compiled, Electron launched, MCP sync log emitted Not-tested: Long-running interactive desktop session after startup * fix(figma): preserve cropped image fill transforms The synced branch started exporting original image dimensions but dropped the existing crop transform semantics from the shared image-fill type and both Figma mappers. That broke the new regression test and stripped metadata that AI consumer-view/bundle code already relies on. Constraint: keep app and package Figma mappers in lockstep Rejected: loosen the new regression test | would hide a real metadata regression Confidence: high Scope-risk: narrow Reversibility: clean Directive: when extending image fill metadata, update shared pen-types and both Figma mapper copies together Tested: bun --bun run test (148/149 files passed; only server/__tests__/sse-keepalive.test.ts blocked by missing agent_napi.node), cd apps/web && bun --bun vitest run src/canvas/skia/drag-reparent-policy.test.ts src/components/panels/layer-dnd-utils.test.ts src/stores/document-position-utils.test.ts src/components/panels/code-panel.test.tsx ../../packages/pen-renderer/src/__tests__/document-flattener.test.ts ../../packages/pen-figma/src/figma-fill-mapper.test.ts, cd apps/web && bun --bun vitest run src/services/ai/__tests__/codegen-assets.test.ts src/services/ai/__tests__/structure-bundle.test.ts src/services/ai/__tests__/consumer-view-enrichment.test.ts, cd apps/web && bun --bun vitest run src/utils/__tests__/security.test.ts, bun test scripts/loopback-no-proxy.test.ts, npx tsc --noEmit, bun --bun run build Not-tested: server/__tests__/sse-keepalive.test.ts without a locally built @zseven-w/agent-native addon * docs(editor): normalize new PR comments to English The PR had a handful of newly introduced Chinese code comments in dev, sync, and AI helper paths. This follow-up keeps the implementation unchanged while translating those comments to English so the PR stays consistent with the repository comment-language expectation. Constraint: The request was limited to comment language cleanup after the conflict-resolution merge, so behavior had to remain unchanged Rejected: Leave the mixed-language comments in place | conflicts with the PR requirement for English comments Rejected: Broader repository-wide translation sweep | unnecessary scope expansion beyond the PR-introduced comments Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep code comments in English on this branch, even when local notes or working memory are in another language Tested: bun test scripts/loopback-no-proxy.test.ts apps/desktop/__tests__/dev-utils.test.ts; cd apps/web && bun --bun vitest run server/__tests__/mcp-sync-state-active.test.ts src/canvas/skia/__tests__/skia-interaction.test.ts; npx tsc --noEmit; branch-diff comment scan for Han characters in comment lines Not-tested: Manual runtime behavior, since this change only rewrote comments * style(editor): apply repository formatting expected by CI The PR was failing the CI Format check after the conflict-resolution and comment-normalization follow-ups. This commit applies the repository formatter output to the files touched by the branch so CI sees the exact formatting it expects, without changing behavior. Constraint: The failing GitHub Actions job stopped at Format check, so the fix had to match oxfmt output rather than introduce functional changes Rejected: Leave the branch as-is and rely on local formatting differences being acceptable | CI explicitly rejects the current formatting Rejected: Broader code cleanup beyond formatter output | unnecessary scope while repairing the failing check Confidence: high Scope-risk: narrow Reversibility: clean Directive: After conflict resolution or comment-only edits on this repo, run bun run format:check before pushing because formatter expectations are stricter than the existing file style in some touched files Tested: bun run format:check; bun run lint; npx tsc --noEmit Not-tested: Full test suite after this formatting-only commit (previous run showed formatting was the first CI blocker) * refactor(editor): remove proxy-specific dev workarounds from PR The PR no longer needs the loopback proxy bypass layer, so this cleanup removes the proxy-specific dev entrypoint, environment bootstrap, helper module, and its tests while keeping the unrelated Electron and AI handoff changes intact. Constraint: Removal had to be limited to proxy-related code on PR #104 without undoing the other merged fixes on the branch Rejected: Keep the helper and stop using it | leaves proxy-specific maintenance surface and tests in the PR Rejected: Revert the entire Electron dev file to upstream earlier than necessary | would risk dropping unrelated local conflict-resolution choices beyond the proxy scope Confidence: high Scope-risk: moderate Reversibility: clean Directive: If proxy handling is reintroduced later, keep it out of this PR unless there is a dedicated, separately justified change for it Tested: bun run format:check; bun run lint; npx tsc --noEmit Not-tested: Manual electron:dev behavior after removing the proxy-specific launcher path * docs(ai): translate JSON-facing semantic descriptions to English The PR still emitted Chinese semantic description strings inside the AI consumer-view and structure-bundle JSON outputs. This change translates those JSON-facing runtime descriptions and updates the affected tests so exported AI-facing structure data is consistently English. Constraint: The request was limited to JSON description strings, so the change had to preserve the same semantics and structure while only translating output text Rejected: Leave Chinese test fixtures and runtime descriptions in place | conflicts with the requirement for English JSON descriptions Rejected: Broader i18n cleanup outside these AI JSON description paths | unnecessary scope expansion beyond the requested exported-description surface Confidence: high Scope-risk: moderate Reversibility: clean Directive: Keep AI/exported JSON explanation strings in English unless a future change explicitly adds localized output modes Tested: cd apps/web && bun --bun vitest run src/services/ai/__tests__/consumer-view-enrichment.test.ts src/services/ai/__tests__/structure-bundle.test.ts src/services/ai/__tests__/codegen-assets.test.ts; bun run format:check; npx tsc --noEmit Not-tested: Full app runtime flows that consume these JSON descriptions outside the covered unit tests * refactor(ai): remove remaining network-proxy handling The current project still carried Anthropic proxy-specific heuristics and environment handling outside the PR-specific cleanup. Since the earlier crashes and connectivity issues were unrelated to proxying, this removes the remaining network-proxy branches, model remapping, and TLS override advice while leaving unrelated request flows intact. Constraint: The cleanup needed to remove proxy-specific logic without disturbing unrelated transport concepts such as app-internal API proxy routes or React proxy objects used in tests Rejected: Keep the proxy heuristics as dormant fallback logic | preserves misleading operational guidance and dead maintenance surface Rejected: Rename every remaining literal use of the word proxy in the repo | would overreach into unrelated concepts like internal API proxying and JS Proxy-based test setup Confidence: medium Scope-risk: moderate Reversibility: clean Directive: If endpoint-specific compatibility logic is needed later, add it as explicit endpoint handling rather than generic proxy heuristics Tested: bun run format:check; bun run lint; npx tsc --noEmit; repo-wide search for network-proxy env references after cleanup Not-tested: End-to-end Claude connection flows against custom base URLs after removing proxy-specific remapping * fix(electron): keep Node-backed dev launch for Nitro compatibility Comparing against upstream commit7271a03confirms the current Electron dev fix is not the same idea as the original Bun-based launcher. The upstream version starts Vite with Bun, while the observed failure shows Nitro now crashes in that path with "Vite environment nitro is unavailable". This keeps the non-proxy Node-backed launcher because it fixes the actual regression without restoring the removed proxy code. Constraint: The request preferred reverting to the upstream original only if the intent matched, but the current Nitro/Electron failure proves the upstream Bun launcher is no longer equivalent in behavior Rejected: Restore the exact7271a03Bun launcher | reproduces the Nitro dev-worker crash and ERR_EMPTY_RESPONSE in Electron Rejected: Reintroduce the old proxy workaround bundle | unrelated to the reproduced failure and already removed by request Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep Electron dev on the Node-backed Vite launcher unless Nitro/Bun dev compatibility is revalidated with a real startup test Tested: bun run electron:dev (reached Electron launch after Vite/MCP/Electron compile steps); bun test apps/desktop/__tests__/dev-utils.test.ts; bun run format:check; npx tsc --noEmit Not-tested: Full interactive manual editor workflow after Electron launch --------- Co-authored-by: Fini <fini.yang@gmail.com> * fix(ai,cli): openai-compat turn-2, StepFun reasoning+451, Mac CLI discovery Round up the v0.7.2 stability fixes for AI connectivity and local CLI detection that surfaced during real user runs against GLM, StepFun, and Mac users on nvm/fnm/pnpm/bun/mise/asdf/fish shells. Provider (via @zseven-w/agent-native v0.3.0 submodule bump): - OpenAI-compat providers can now complete multi-turn tool-calling loops: the request builder translates Anthropic-shaped message history (tool_use / tool_result blocks, thinking) into OpenAI's tool_calls + role="tool" form so turn 2 no longer 400s. system_prompt is finally injected instead of being silently dropped. - The SSE parser accepts `delta.reasoning` (StepFun step_plan) alongside `reasoning_content` (GLM / DeepSeek / Qwen), and also streams tool_call fragments, which unblocks GLM / dashscope and stops the firstTextTimeout → fetch abort → std.http panic → Bun segfault cascade. - HTTP 451 (StepFun content-safety) surfaces as InvalidRequest with a specific "content blocked by provider safety filter" message instead of an opaque error_server. Server route + client watchdog: - /api/ai/chat forwards the provider's last_error string (result.errors[0]) so users see "HTTP 451 content blocked" rather than "Provider error: error_server". - streamChat clears firstTextTimeout on thinking chunks (when thinkingResetsTimeout=true), so models that stream long reasoning before any text aren't falsely killed as "stuck". Orchestrator sub-agent resilience: - Failed sub-agents (empty response / unparseable output) now retry once with a minimal ~3KB kernel prompt (schema + jsonl-format only). Only the failing subtask re-runs — successful earlier sections are kept. - Deterministic refusals (HTTP 400/401/429/451, "content blocked", "censorship", "authentication failed") short-circuit the retry ladder so a 4-minute StepFun safety scan isn't spent twice in a row. Local CLI discovery (Mac users on managed shells): - New server/utils/cli-resolver-helpers.ts exports probeViaLoginShell() and posixUserBinDirs(). Login-shell probe asks $SHELL (or zsh/bash fallback — fish added at /opt/homebrew/bin/fish and friends) with `-ilc 'command -v <cli>'` so nvm/pnpm/bun/mise/asdf/volta/fnm shims are visible even when Electron scrubs the inherited PATH. - resolveClaudeCli / resolveGeminiCli / resolveCopilotCli and the inline codex/opencode resolvers in connect-agent.ts all run the same PATH → login-shell → npm-prefix → user-bin candidates ladder. Each step logs via serverLog to ~/.openpencil/logs/server-YYYY-MM-DD.log for remote diagnosis. Builtin provider preset: - Add StepFun Coding Plan (api.stepfun.com/step_plan/v1, label "StepFun Coding Plan") alongside the existing StepFun preset. Version bump 0.7.1 → 0.7.2 across all workspaces. --------- Co-authored-by: RaisCui <857943+raiscui@users.noreply.github.com> Co-authored-by: Fini <fini.yang@gmail.com>
23 lines
482 B
JSON
23 lines
482 B
JSON
{
|
|
"name": "@zseven-w/pen-acp",
|
|
"version": "0.7.2",
|
|
"description": "ACP (Agent Client Protocol) client for OpenPencil — connect to external ACP agents",
|
|
"files": [
|
|
"src"
|
|
],
|
|
"type": "module",
|
|
"exports": {
|
|
".": {
|
|
"types": "./src/index.ts",
|
|
"import": "./src/index.ts"
|
|
}
|
|
},
|
|
"dependencies": {
|
|
"@agentclientprotocol/sdk": "^0.18.2",
|
|
"ws": "^8.18.0"
|
|
},
|
|
"devDependencies": {
|
|
"@types/ws": "^8.5.0",
|
|
"typescript": "^5.7.2"
|
|
}
|
|
}
|