vndangkhoa/openpencil
1
0
Fork 0
mirror of https://github.com/ZSeven-W/openpencil.git synced 2026-06-01 03:14:29 +07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(ai): scope role part-word guard to the FIRST word after role keyword

Browse source 
Follow-up on d45f1a5. The previous pass switched to a suffix scan so
"Icon Button" (part word before role) kept its button role, but the
suffix scan still used a substring regex — it fired on any part word
anywhere in the tail. That misclassified realistic prepositional
variants:

    "Card with Icon"  → after="with icon", 'icon' matched → skipped
                      → fell through to /\bicon\b/ → role='icon' ❌
    "Button with Image" → similar → role='icon' ❌
    "Card with Header"  → skipped → role=null ❌

These names describe the role AS A WHOLE ("a card that has an icon",
"a button with an image"), not a piece of it, and should keep their
role.

Switch the guard to examine only the FIRST word token of the suffix:

    "Card Header"      → first="header"   → part → skip ✓
    "Card with Icon"   → first="with"     → keep ✓
    "Button with Label"→ first="with"     → keep ✓
    "Card - Header"    → first="header"   → part → skip ✓ (punct stripped)
    "Icon Button"      → suffix empty     → keep ✓

Store ROLE_PART_WORDS as a Set (with a small firstWordToken helper that
uses /\w+/ to skip leading whitespace and punctuation) instead of a
regex, so the semantics are unambiguous: "is the first word of the
suffix one of these exact tokens".

Inline coverage extended to 38 role cases, adding 6 prepositional
variants (with icon / with image / with header / with label) for both
button and card, plus two punctuation cases (Card - Header, Card: Body).
This commit is contained in:
Fini 2026-04-06 19:22:04 +08:00
parent d45f1a573b
commit f8428538f7
1 changed files with 56 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

68
apps/web/src/services/ai/role-resolver.ts
View file

@ -106,12 +106,53 @@ const CONTAINER_SUFFIXES = /\b(group|row|container|wrapper|section|list|area|sta
/** /**
* Words that, when combined with a role-like word, turn the node into a * Words that, when combined with a role-like word, turn the node into a
* PART of that role rather than an instance of it. "Card Header", * PART of that role rather than an instance of it. "Card Header",
* "Card Body", "Card Footer", "Button Group", "Nav Link Wrapper" are all * "Card Body", "Card Footer" are all structural pieces inside a parent
* structural pieces inside a parent component — they must NOT inherit the * card — they must NOT inherit the card's role defaults (white fill,
* parent component's role defaults (white fill, shadow, rounded corners…). * shadow, rounded corners…).
*
* Stored as a Set (not a regex) because the check is "is the first word
* after the role keyword exactly one of these" — position-sensitive and
* word-scoped, not a substring scan. A substring scan would wrongly
* reject prepositional variants like "Card with Icon" or "Button with
* Image", where the part word is separated from the role word by a
* modifier ("with") and the whole name describes a variant of the role
* rather than an internal piece of it.
*/ */
const ROLE_PART_WORDS = const ROLE_PART_WORDS = new Set([
/\b(header|body|footer|title|subtitle|content|wrapper|container|area|label|value|caption|description|image|media|icon|action|actions|meta|row|column|stack|grid)\b/i; 'header',
'body',
'footer',
'title',
'subtitle',
'content',
'wrapper',
'container',
'area',
'label',
'value',
'caption',
'description',
'image',
'media',
'icon',
'action',
'actions',
'meta',
'row',
'column',
'stack',
'grid',
]);
/**
* Extract the first word-like token from a string, skipping any leading
* whitespace, punctuation, or separators. Returns null when the string
* has no word characters. Used by the suffix-scan guard below.
*/
function firstWordToken(s: string): string | null {
const m = /\w+/.exec(s);
return m ? m[0] : null;
}
/** Substring patterns → role (checked in order, first match wins). */ /** Substring patterns → role (checked in order, first match wins). */
const NAME_PATTERN_MAP: [RegExp, string, boolean?][] = [ const NAME_PATTERN_MAP: [RegExp, string, boolean?][] = [
@ -155,14 +196,17 @@ function inferRoleFromName(node: PenNode): string | undefined {
// Skip container-like names (e.g. "Button Group", "Buttons Row") // Skip container-like names (e.g. "Button Group", "Buttons Row")
if (CONTAINER_SUFFIXES.test(lower)) continue; if (CONTAINER_SUFFIXES.test(lower)) continue;
// Skip "Card Header", "Card Body", "Button Label", etc. — when the // Skip "Card Header", "Card Body", "Button Label", etc. — when the
// part word appears AFTER the role word, the node is a PIECE of // FIRST word after the role keyword is a part word, the node is a
// the role, not the role itself. Crucially, we only look at the // PIECE of the role. Two positional guards matter here:
// text AFTER the match: "Icon Button" must still become 'button', // 1. We look at the text AFTER the match, so "Icon Button"
// because there the part word ("icon") appears BEFORE the role // (part word before role) is correctly kept as button.
// word and is just a modifier ("a button of the icon variety"), // 2. We only check the FIRST word in that suffix, so
// not an internal piece of the button. // "Card with Icon" / "Button with Image" (prepositional
// variants: "a card that HAS an icon") keep their role —
// the first word is "with", not a part word.
const afterMatch = lower.slice(match.index + match[0].length); const afterMatch = lower.slice(match.index + match[0].length);
if (ROLE_PART_WORDS.test(afterMatch)) continue; const nextWord = firstWordToken(afterMatch);
if (nextWord && ROLE_PART_WORDS.has(nextWord)) continue;
} }
return role; return role;
} }