mirror of
https://github.com/ZSeven-W/openpencil.git
synced 2026-05-31 19:04:29 +07:00
fix(ci): protect op-design-lint goldens from oxfmt + restore TS-oracle format
CI 'Fail on golden drift' (rust-check.yml) was red because oxfmt inlined the 4-element padding arrays in the committed goldens, while the TS oracle's `JSON.stringify(value, null, 2)` emits them multi-line. Every `bun run format` would re-introduce the drift. Fix: - .prettierignore: ignore crates/op-design-lint/tests/fixtures/golden/ so oxfmt leaves them at the TS-oracle byte-exact format. - regenerate the two affected goldens via the oracle (edge-section-padding.json, stacked-horizontal-padding.json) so they match what the CI drift guard expects. `bun run tools/dump-diagnostics-golden.ts` + `git diff` now clean. `cargo test -p op-design-lint` 149/149 green. fmt-check clean. This was the only red workflow on the v0.8.0-new push; CI should be fully green after this lands.
This commit is contained in:
parent
845e5ae7b5
commit
6104fa277a
3 changed files with 20 additions and 2 deletions
|
|
@ -15,6 +15,14 @@ target/
|
||||||
# Auto-generated by @tanstack/router-plugin.
|
# Auto-generated by @tanstack/router-plugin.
|
||||||
apps/web/src/routeTree.gen.ts
|
apps/web/src/routeTree.gen.ts
|
||||||
|
|
||||||
|
# op-design-lint TS-oracle parity goldens — regenerated by
|
||||||
|
# `tools/dump-diagnostics-golden.ts` via `JSON.stringify(value, null, 2)`,
|
||||||
|
# which keeps 4-element arrays multi-line. oxfmt's `printWidth: 100`
|
||||||
|
# inlines them, causing the CI drift guard (rust-check.yml: "Fail on
|
||||||
|
# golden drift") to red on every push. Keep these byte-identical to
|
||||||
|
# what the TS oracle emits.
|
||||||
|
crates/op-design-lint/tests/fixtures/golden/
|
||||||
|
|
||||||
# Local scratch / tutorial outputs (not part of the codebase; users won't have these dirs).
|
# Local scratch / tutorial outputs (not part of the codebase; users won't have these dirs).
|
||||||
.baoyu-skills/
|
.baoyu-skills/
|
||||||
xhs-images/
|
xhs-images/
|
||||||
|
|
|
||||||
|
|
@ -5,7 +5,12 @@
|
||||||
"severity": "warning",
|
"severity": "warning",
|
||||||
"property": "padding",
|
"property": "padding",
|
||||||
"currentValue": null,
|
"currentValue": null,
|
||||||
"suggestedValue": [0, 16, 0, 16],
|
"suggestedValue": [
|
||||||
|
0,
|
||||||
|
16,
|
||||||
|
0,
|
||||||
|
16
|
||||||
|
],
|
||||||
"reason": "mobile root has 0 horizontal padding while 2 content section(s) glue text/icon to screen edge"
|
"reason": "mobile root has 0 horizontal padding while 2 content section(s) glue text/icon to screen edge"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
|
|
|
||||||
|
|
@ -4,7 +4,12 @@
|
||||||
"category": "stacked-horizontal-padding",
|
"category": "stacked-horizontal-padding",
|
||||||
"severity": "info",
|
"severity": "info",
|
||||||
"property": "padding",
|
"property": "padding",
|
||||||
"currentValue": [0, 24, 0, 24],
|
"currentValue": [
|
||||||
|
0,
|
||||||
|
24,
|
||||||
|
0,
|
||||||
|
24
|
||||||
|
],
|
||||||
"suggestedValue": null,
|
"suggestedValue": null,
|
||||||
"reason": "section h-padding [24/24] stacks with root h-padding [16/16] — combined gutter 40/40"
|
"reason": "section h-padding [24/24] stacks with root h-padding [16/16] — combined gutter 40/40"
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue