mirror of
https://github.com/nexu-io/open-design.git
synced 2026-06-01 03:14:35 +07:00
* docs(xiaohongshu): address review feedback from #24 Ten review notes from #24, eight applied in this file, one tracked in PR body, one explicitly deferred per reviewer guidance. - §2: clarify the brand-red split — the +6 red-channel shift between #FF2442 (token) and #FF2E4D (component layer) is documented as intent-undocumented-upstream rather than left implicit. - §2: add a heads-up that danger reuses --primary, so destructive actions and primary CTAs are visually identical out of the box; recommend outline + brand-red text or a leading destructive icon as a defensive default. - §2: state dark-mode trigger explicitly (prefers-color-scheme + manual override; both :root[dark] and .force-dark honored). - §5: explain *why* the masonry uses translate3d + ResizeObserver rather than CSS Masonry — the latter is still flagged in most browsers as of 2026. - §6: add a dark-mode row to the elevation table; alpha-on-black shadows are invisible on the #19191E canvas, so drop hover shadows and replace modal shadow with a 1px hairline at rgba(255,255,255,.07). - §7: forbid fabricating the 小红书 wordmark / RED logotype as artifact output (tokens are not protectable, the wordmark is — emit a labelled grey block instead). - §7: forbid referencing RED Number standalone in generated CSS without the PingFang fallback chain. - §7: add a concrete shadow threshold to the heavy-shadows Don't — alpha > 0.15 or spread > 16px is the cutoff. - §9: new "Brand Red Disambiguation" subsection at the top of the Agent Prompt Guide making the per-surface rule explicit (default: #FF2442; pixel-replica only: #FF2E4D; never mix on one component). Schema-drift between CONTRIBUTING.md and the bundled design-system corpus is intentionally not addressed here — the reviewer flagged it as a wider-scope cleanup affecting all ~70 systems and explicitly said "no action requested in this PR" if treated as such. * docs(xiaohongshu): correct channel-delta in brand-red rationale Codex review bot caught a numerical error in #54: #FF2442 → #FF2E4D is not "+6 on the red channel" — both colors share the same red channel (FF = 255). The actual delta is +10 on green (24 → 2E) and +11 on blue (42 → 4D), which together raise lightness slightly and shift the hue a touch toward pink. Document review badge: P2. |
||
|---|---|---|
| .. | ||
| DESIGN.md | ||