mirror of
https://github.com/nexu-io/open-design.git
synced 2026-06-01 03:14:35 +07:00
027df91ab5
1. spawnEnvForAgent now validates inherited CODEBUDDY_INTERNET_ENVIRONMENT against the closed enum (public/internal/ioa). Invalid inherited values (e.g. a typo like "internel") are dropped with a console.warn so the child process falls back to the international default instead of failing with a confusing auth/connectivity error. 2. Custom-endpoint transport error detection broadened beyond ConnectionRefused to also cover ENOTFOUND, ETIMEDOUT, EAI_AGAIN, ECONNRESET, and common TLS/certificate errors. The diagnostic message now describes the full range of network failures instead of only "refused the connection". Added regression tests for: - Invalid inherited INTERNET_ENVIRONMENT dropped with warning - DNS failure (ENOTFOUND) endpoint guidance - Timeout (ETIMEDOUT) endpoint guidance - TLS error endpoint guidance
419 lines
15 KiB
TypeScript
419 lines
15 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import { diagnoseClaudeCliFailure } from '../src/claude-diagnostics.js';
|
|
|
|
describe('diagnoseClaudeCliFailure', () => {
|
|
it('maps Claude Not logged in stdout to /login guidance (#1928)', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stdoutTail: 'Not logged in · Please run /login.',
|
|
env: {},
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('/login');
|
|
expect(diagnostic?.detail).toContain('CLAUDE_CONFIG_DIR');
|
|
});
|
|
|
|
it('maps Claude auth failures to /login guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stderrTail: '{"apiKeySource":"none","error_status":401}',
|
|
env: {},
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('/login');
|
|
expect(diagnostic?.detail).toContain('CLAUDE_CONFIG_DIR');
|
|
});
|
|
|
|
it('maps custom endpoint model access failures to endpoint guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stderrTail:
|
|
'Error: The selected model is not available in your current plan or region.',
|
|
env: { ANTHROPIC_BASE_URL: 'https://proxy.example.com' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('custom endpoint');
|
|
expect(diagnostic?.detail).toContain('ANTHROPIC_BASE_URL');
|
|
});
|
|
|
|
it('maps custom endpoint auth failures to endpoint credential guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stderrTail: '{"apiKeySource":"none","error_status":401}',
|
|
env: { ANTHROPIC_BASE_URL: 'https://proxy.example.com' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('custom Anthropic endpoint');
|
|
expect(diagnostic?.detail).toContain('ANTHROPIC_BASE_URL');
|
|
expect(diagnostic?.detail).toContain('proxy credentials');
|
|
expect(diagnostic?.detail).not.toContain('use `/login`');
|
|
});
|
|
|
|
it('maps custom endpoint connection refusals before generic auth guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stderrTail:
|
|
'{"apiKeySource":"none"} API Error: Unable to connect to API (ConnectionRefused)',
|
|
env: { ANTHROPIC_BASE_URL: 'http://127.0.0.1:1337' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('could not reach');
|
|
expect(diagnostic?.detail).toContain('ANTHROPIC_BASE_URL');
|
|
expect(diagnostic?.detail).toContain('could not be reached');
|
|
expect(diagnostic?.detail).not.toContain('could not authenticate');
|
|
expect(diagnostic?.detail).not.toContain('use `/login`');
|
|
});
|
|
|
|
it('maps custom endpoint DNS failures (ENOTFOUND) to endpoint guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stderrTail: 'Error: getaddrinfo ENOTFOUND proxy.internal.local',
|
|
env: { ANTHROPIC_BASE_URL: 'https://proxy.internal.local' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('could not reach');
|
|
expect(diagnostic?.detail).toContain('ANTHROPIC_BASE_URL');
|
|
expect(diagnostic?.detail).not.toContain('could not authenticate');
|
|
});
|
|
|
|
it('maps custom endpoint timeout (ETIMEDOUT) to endpoint guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stderrTail: 'Error: connect ETIMEDOUT 10.0.0.1:443',
|
|
env: { ANTHROPIC_BASE_URL: 'https://slow-proxy.example.com' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('could not reach');
|
|
expect(diagnostic?.detail).toContain('ANTHROPIC_BASE_URL');
|
|
});
|
|
|
|
it('maps CodeBuddy custom endpoint TLS errors to endpoint guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: 'Error: unable to verify the first certificate',
|
|
env: { CODEBUDDY_BASE_URL: 'https://self-signed.example.com' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('could not reach');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_BASE_URL');
|
|
});
|
|
|
|
it('maps silent custom endpoint exits to endpoint guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stderrTail: '',
|
|
stdoutTail: '',
|
|
env: { ANTHROPIC_BASE_URL: 'https://proxy.example.com' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('custom Anthropic endpoint');
|
|
expect(diagnostic?.detail).toContain('ANTHROPIC_BASE_URL');
|
|
expect(diagnostic?.detail).toContain('proxy credentials');
|
|
expect(diagnostic?.detail).not.toContain('use `/login`');
|
|
});
|
|
|
|
it('maps silent configured-profile exits to profile guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stderrTail: '',
|
|
stdoutTail: '',
|
|
env: { CLAUDE_CONFIG_DIR: '/tmp/claude-alt' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('configured Claude profile');
|
|
expect(diagnostic?.detail).toContain('Re-run `claude` and `/login` for that profile');
|
|
expect(diagnostic?.detail).toContain('Effective CLAUDE_CONFIG_DIR: /tmp/claude-alt');
|
|
});
|
|
|
|
it('includes configured Claude config directory context', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stderrTail: 'Authentication failed: token expired',
|
|
env: { CLAUDE_CONFIG_DIR: '/tmp/claude-alt' },
|
|
});
|
|
|
|
expect(diagnostic?.detail).toContain('Effective CLAUDE_CONFIG_DIR: /tmp/claude-alt');
|
|
});
|
|
|
|
it('maps CodeBuddy auth failures without API key to API key setup guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: '{"apiKeySource":"none","error_status":401}',
|
|
env: {},
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('CodeBuddy Code');
|
|
expect(diagnostic?.message).toContain('API key');
|
|
expect(diagnostic?.message).toContain('No API key');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_API_KEY');
|
|
expect(diagnostic?.detail).not.toContain('/login');
|
|
});
|
|
|
|
it('maps CodeBuddy custom endpoint auth failures without API key to setup guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: '{"apiKeySource":"none","error_status":401}',
|
|
env: { CODEBUDDY_BASE_URL: 'https://proxy.example.com' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('custom CodeBuddy endpoint');
|
|
expect(diagnostic?.message).toContain('API key');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_API_KEY');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_BASE_URL');
|
|
expect(diagnostic?.detail).not.toContain('/login');
|
|
});
|
|
|
|
it('maps CodeBuddy custom endpoint auth failures with API key to key-check guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: '{"apiKeySource":"none","error_status":401}',
|
|
env: { CODEBUDDY_BASE_URL: 'https://proxy.example.com', CODEBUDDY_API_KEY: 'cb-test-key' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('custom CodeBuddy endpoint');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_API_KEY');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_BASE_URL');
|
|
expect(diagnostic?.detail).not.toContain('/login');
|
|
});
|
|
|
|
it('maps CodeBuddy silent configured-profile exits to API key guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: '',
|
|
stdoutTail: '',
|
|
env: { CODEBUDDY_CONFIG_DIR: '/tmp/codebuddy-alt' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('CodeBuddy');
|
|
expect(diagnostic?.message).toContain('API key');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_API_KEY');
|
|
expect(diagnostic?.detail).not.toContain('/login');
|
|
});
|
|
|
|
it('maps CodeBuddy auth failures with API key set to API key guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: '{"apiKeySource":"none","error_status":401}',
|
|
env: { CODEBUDDY_API_KEY: 'cb-test-key' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('API key');
|
|
expect(diagnostic?.message).toContain('CodeBuddy');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_API_KEY');
|
|
expect(diagnostic?.detail).not.toContain('/login');
|
|
});
|
|
|
|
it('maps CodeBuddy auth failures with API key and config dir to combined guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: '{"apiKeySource":"none","error_status":401}',
|
|
env: {
|
|
CODEBUDDY_API_KEY: 'cb-test-key',
|
|
CODEBUDDY_CONFIG_DIR: '/tmp/codebuddy-alt',
|
|
},
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('API key');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_API_KEY');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_CONFIG_DIR');
|
|
expect(diagnostic?.detail).not.toContain('/login');
|
|
});
|
|
|
|
it('maps CodeBuddy config state failures without API key to API key setup guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: 'OAuth credential expired for session',
|
|
env: {},
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('CodeBuddy Code');
|
|
expect(diagnostic?.message).toContain('API key');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_API_KEY');
|
|
expect(diagnostic?.detail).not.toContain('/login');
|
|
});
|
|
|
|
it('maps CodeBuddy config-state failure with API key to key-check guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: 'OAuth credential expired for session',
|
|
env: { CODEBUDDY_API_KEY: 'cb-test-key' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('CodeBuddy');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_API_KEY');
|
|
expect(diagnostic?.detail).not.toContain('/login');
|
|
});
|
|
|
|
it('maps CodeBuddy silent exit with API key to key-check guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: '',
|
|
stdoutTail: '',
|
|
env: { CODEBUDDY_API_KEY: 'cb-test-key' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('CodeBuddy');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_API_KEY');
|
|
expect(diagnostic?.detail).not.toContain('/login');
|
|
});
|
|
|
|
it('reports effective CODEBUDDY_INTERNET_ENVIRONMENT in CodeBuddy diagnostic context', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: '{"apiKeySource":"none","error_status":401}',
|
|
env: { CODEBUDDY_INTERNET_ENVIRONMENT: 'internal' },
|
|
});
|
|
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_INTERNET_ENVIRONMENT=internal');
|
|
});
|
|
|
|
it('reports effective CODEBUDDY_INTERNET_ENVIRONMENT with configured value', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: '{"apiKeySource":"none","error_status":401}',
|
|
env: { CODEBUDDY_API_KEY: 'cb-test-key', CODEBUDDY_INTERNET_ENVIRONMENT: 'ioa' },
|
|
});
|
|
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_INTERNET_ENVIRONMENT=ioa');
|
|
});
|
|
|
|
it('does not report CODEBUDDY_INTERNET_ENVIRONMENT when unset', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: '{"apiKeySource":"none","error_status":401}',
|
|
env: { CODEBUDDY_API_KEY: 'cb-test-key' },
|
|
});
|
|
|
|
expect(diagnostic?.detail).not.toContain('CODEBUDDY_INTERNET_ENVIRONMENT');
|
|
});
|
|
|
|
it('maps CodeBuddy silent custom-endpoint exit without API key to setup guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: '',
|
|
stdoutTail: '',
|
|
env: { CODEBUDDY_BASE_URL: 'https://proxy.example.com' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('custom CodeBuddy endpoint');
|
|
expect(diagnostic?.message).toContain('No API key');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_API_KEY');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_BASE_URL');
|
|
expect(diagnostic?.detail).not.toContain('/login');
|
|
});
|
|
|
|
it('maps CodeBuddy silent custom-endpoint exit with API key to key-check guidance', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codebuddy',
|
|
exitCode: 1,
|
|
stderrTail: '',
|
|
stdoutTail: '',
|
|
env: { CODEBUDDY_BASE_URL: 'https://proxy.example.com', CODEBUDDY_API_KEY: 'cb-test-key' },
|
|
});
|
|
|
|
expect(diagnostic?.message).toContain('custom CodeBuddy endpoint');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_API_KEY');
|
|
expect(diagnostic?.detail).toContain('CODEBUDDY_BASE_URL');
|
|
expect(diagnostic?.detail).not.toContain('/login');
|
|
});
|
|
|
|
it('does not classify unrelated agent failures', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'codex',
|
|
exitCode: 1,
|
|
stderrTail: 'Authentication failed',
|
|
env: {},
|
|
});
|
|
|
|
expect(diagnostic).toBeNull();
|
|
});
|
|
|
|
it('redacts token-like text from returned details', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stderrTail: '401 Authorization: Bearer abcdef0123456789ABCDEF==',
|
|
env: {},
|
|
});
|
|
|
|
expect(diagnostic?.detail).not.toContain('abcdef0123456789ABCDEF');
|
|
expect(diagnostic?.detail).toContain('[REDACTED:bearer_token]');
|
|
});
|
|
|
|
it('redacts provider header and query API keys from returned details', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stderrTail:
|
|
'401 x-api-key: header-secret-123 url=https://proxy.example.test/v1?key=query-secret-456',
|
|
env: { ANTHROPIC_BASE_URL: 'https://proxy.example.test' },
|
|
});
|
|
|
|
expect(diagnostic?.detail).not.toContain('header-secret-123');
|
|
expect(diagnostic?.detail).not.toContain('query-secret-456');
|
|
expect(diagnostic?.detail).toContain('x-api-key: [REDACTED:api_key_header]');
|
|
expect(diagnostic?.detail).toContain('?key=[REDACTED:api_key_query]');
|
|
});
|
|
|
|
it('redacts quoted provider API key headers from returned details', () => {
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stderrTail: '401 {"x-api-key":"secret-value-123"}',
|
|
env: { ANTHROPIC_BASE_URL: 'https://proxy.example.test' },
|
|
});
|
|
|
|
expect(diagnostic?.detail).not.toContain('secret-value-123');
|
|
expect(diagnostic?.detail).toContain('"x-api-key":"[REDACTED:api_key_header]"');
|
|
});
|
|
|
|
it('redacts long bearer tokens before taking the diagnostic tail', () => {
|
|
const credential = 'a'.repeat(300);
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stderrTail: `401 Authorization: Bearer ${credential}`,
|
|
env: {},
|
|
});
|
|
|
|
expect(diagnostic?.detail).not.toContain('a'.repeat(80));
|
|
expect(diagnostic?.detail).toContain('[REDACTED:bearer_token]');
|
|
});
|
|
|
|
it('redacts long provider API key headers before taking the diagnostic tail', () => {
|
|
const credential = 'b'.repeat(300);
|
|
const diagnostic = diagnoseClaudeCliFailure({
|
|
agentId: 'claude',
|
|
exitCode: 1,
|
|
stderrTail: `401 x-api-key: ${credential}`,
|
|
env: { ANTHROPIC_BASE_URL: 'https://proxy.example.test' },
|
|
});
|
|
|
|
expect(diagnostic?.detail).not.toContain('b'.repeat(80));
|
|
expect(diagnostic?.detail).toContain('x-api-key: [REDACTED:api_key_header]');
|
|
});
|
|
});
|