mirror of
https://github.com/nexu-io/open-design.git
synced 2026-06-01 03:14:35 +07:00
0bd07b2a3d
* fix(daemon): grok-build runtime — pass prompt inline as -p value, drop stdin Grok Build CLI 0.1.212 enforces `-p, --single <PROMPT>` as a value-requiring flag — invoking with bare `-p` and piping the prompt to stdin now fails with: error: a value is required for '--single <PROMPT>' but none was supplied The previous runtime def used `promptViaStdin: true` + `buildArgs` returning `['-p']`, which only worked against earlier grok builds that read the prompt from stdin when `-p` had no inline value. This change inlines the prompt as the `-p` argument value and flips `promptViaStdin: false`. Linux `MAX_ARG_STRLEN` (128 KB) is enough headroom for typical Open Design prompts; if we ever hit `E2BIG` on a very large brief, a follow-up could shell out to `--prompt-file <tempfile>`. Verified against grok 0.1.212 (b7b8204a4) — single-turn invocations now return clean text replies instead of exit 2. * fix(daemon): declare grok-build argv prompt budget + regression coverage @mrcfps' review on #2259 flagged that moving the Grok Build adapter from the (no-longer-working) stdin path to argv would regress oversized composed prompts from the actionable AGENT_PROMPT_TOO_LARGE error we already emit for DeepSeek to a raw spawn ENAMETOOLONG / E2BIG instead. Fixed by mirroring the DeepSeek argv-budget shape: - grok-build.ts: `maxPromptArgBytes: 30_000` (same headroom as DeepSeek, ~2.7 KB under the Windows CreateProcess 32_767-char cap) so `checkPromptArgvBudget` pre-flights composed prompts (system + history + skills + design-system content + user message) before spawn. - prompt-budget.ts: Grok-Build-specific message — names the `-p / --single` flag, the xAI CLI 0.1.212+ behavior change, and points the user at stdin-capable adapters (claude / codex / hermes) when they need to ship large local context. - Tests: 3 new vitest cases in prompt-budget.test.ts — pin the budget field, exercise the strict-overrun + at-limit + CJK byte-count guards exactly like the DeepSeek regression set, and assert the Grok-named diagnostic copy. New `grokBuild` + `grokBuildMaxPromptArgBytes` helpers exported alongside the existing `deepseek*` ones. All 23 prompt-budget tests pass locally (`pnpm exec vitest run tests/runtimes/prompt-budget.test.ts`). --------- Co-authored-by: Sriram Sivakumar <sriram155@gmail.com> Co-authored-by: Siri-Ray <2667192167@qq.com>
89 lines
3.9 KiB
TypeScript
89 lines
3.9 KiB
TypeScript
import { parseLineSeparatedModels, DEFAULT_MODEL_OPTION } from './shared.js';
|
|
import type { RuntimeAgentDef } from '../types.js';
|
|
|
|
// xAI's first-party CLI agent — https://x.ai/cli — distributed as the
|
|
// `grok` binary. Installed via `curl -fsSL https://x.ai/cli/install.sh | bash`,
|
|
// which symlinks `~/.grok/bin/grok` into PATH.
|
|
//
|
|
// `grok` ships its own SuperGrok OAuth dance (same `auth.x.ai` issuer +
|
|
// loopback-redirect shape Open Design's xAI Settings panel uses), so it's
|
|
// already authenticated by the time OD detects the binary; OD does not
|
|
// need to inject credentials. Users authenticate once with `grok login
|
|
// --oauth` and the resulting `~/.grok/auth.json` is what every spawned
|
|
// invocation reads.
|
|
//
|
|
// Headless mode follows Claude Code's pattern (`-p <PROMPT>` for single-
|
|
// turn, `--output-format streaming-json` for structured streaming), but
|
|
// the streaming-json schema is xAI-specific and we do not yet have a
|
|
// daemon-side parser for it. To ship the runtime now and let users at
|
|
// least chat with grok inside OD, this defaults to `plain` streamFormat
|
|
// (single-turn text reply, no tool_use streaming). Upgrading to a
|
|
// `grok-stream-json` event parser is follow-up work once the format is
|
|
// stable enough to lock in.
|
|
export const grokBuildAgentDef = {
|
|
id: 'grok-build',
|
|
name: 'Grok Build',
|
|
bin: 'grok',
|
|
versionArgs: ['--version'],
|
|
helpArgs: ['-p', '--help'],
|
|
// `grok models` prints one model id per line, plus a `Default model:`
|
|
// header line that parseLineSeparatedModels strips because it isn't
|
|
// an id token. Falls back to the static list below when probing fails
|
|
// (no SuperGrok Heavy entitlement on this machine, network blip, etc.).
|
|
listModels: {
|
|
args: ['models'],
|
|
timeoutMs: 10_000,
|
|
parse: parseLineSeparatedModels,
|
|
},
|
|
fallbackModels: [
|
|
DEFAULT_MODEL_OPTION,
|
|
{ id: 'grok-build', label: 'grok-build (xAI · default)' },
|
|
{ id: 'grok-4.3', label: 'grok-4.3 (xAI)' },
|
|
{ id: 'grok-4.20-reasoning', label: 'grok-4.20-reasoning (xAI · deep)' },
|
|
{
|
|
id: 'grok-4.20-non-reasoning',
|
|
label: 'grok-4.20-non-reasoning (xAI · fast)',
|
|
},
|
|
{
|
|
id: 'grok-4.20-multi-agent',
|
|
label: 'grok-4.20-multi-agent (xAI · orchestration)',
|
|
},
|
|
],
|
|
// Grok Build CLI v0.1.212 enforces `-p, --single <PROMPT>` as value-
|
|
// required — stdin piping no longer satisfies it. Inline the prompt.
|
|
buildArgs: (prompt, _imagePaths, _extra = [], options = {}) => {
|
|
const args = ['-p', prompt];
|
|
if (options.model && options.model !== DEFAULT_MODEL_OPTION.id) {
|
|
args.push('--model', options.model);
|
|
}
|
|
if (options.reasoning) {
|
|
args.push('--effort', options.reasoning);
|
|
}
|
|
return args;
|
|
},
|
|
reasoningOptions: [
|
|
{ id: 'low', label: 'low' },
|
|
{ id: 'medium', label: 'medium' },
|
|
{ id: 'high', label: 'high' },
|
|
{ id: 'xhigh', label: 'xhigh' },
|
|
{ id: 'max', label: 'max' },
|
|
],
|
|
promptViaStdin: false,
|
|
// Guard against prompts that would blow Windows' ~32 KB CreateProcess
|
|
// limit (or Linux MAX_ARG_STRLEN on extreme edges) before spawn. Same
|
|
// shape as the DeepSeek adapter — the previous stdin path is gone (CLI
|
|
// 0.1.212 enforces `-p <value>`), so the composed prompt now rides
|
|
// argv and a sufficiently large one — system text + history + skills/
|
|
// design-system content + user message — could surface as a generic
|
|
// spawn ENAMETOOLONG / E2BIG instead of a Grok-specific, user-
|
|
// actionable message. The /api/chat spawn path checks this byte
|
|
// budget against the composed prompt and emits AGENT_PROMPT_TOO_LARGE
|
|
// ("reduce skills/design-system context, or pick an adapter with
|
|
// stdin support") before calling `spawn`. 30_000 bytes leaves ~2.7 KB
|
|
// of argv headroom under the Windows command-line limit for `-p
|
|
// --model <id> --effort <level>` and internal quoting.
|
|
maxPromptArgBytes: 30_000,
|
|
streamFormat: 'plain',
|
|
installUrl: 'https://x.ai/cli',
|
|
docsUrl: 'https://x.ai/cli',
|
|
} satisfies RuntimeAgentDef;
|