diff --git a/.github/workflows/landing-page-ci.yml b/.github/workflows/landing-page-ci.yml index 17910f7c3..20bd128b0 100644 --- a/.github/workflows/landing-page-ci.yml +++ b/.github/workflows/landing-page-ci.yml @@ -20,10 +20,22 @@ on: - design-systems/** - craft/** - templates/** + # Plugin manifests power the bundled-plugin catalog and the new + # `_lib/bundled-plugins.ts` reader; CI must rerun when their + # `title_i18n` / `description_i18n` maps or other fields change. + - plugins/** # Workspace plumbing - package.json - pnpm-lock.yaml - pnpm-workspace.yaml + # Merge queue trigger so PRs that touch the same paths can clear + # `Validate landing page` / `Strict PR visual tests` while queued. + # Without this branch ruleset blocks merges (the queue waits forever + # for a check name that never gets dispatched against the merge_group + # ref), which is the exact deadlock observed during the 5/26 release + # window. + merge_group: + types: [checks_requested] push: branches: - main diff --git a/apps/landing-page/app/_components/header.tsx b/apps/landing-page/app/_components/header.tsx index ba7bf2150..f2fa3e5f6 100644 --- a/apps/landing-page/app/_components/header.tsx +++ b/apps/landing-page/app/_components/header.tsx @@ -173,13 +173,11 @@ export function Header({ {/* - Library — catalog facets (Skills / Systems / Templates / Craft) + Plugins — catalog facets (Templates / Skills / Systems / Craft) collapsed under one parent. Each row keeps its count badge inside the panel and the trigger highlights when any of the four facet pages is active. Same CSS-only :hover / - :focus-within mechanic from Product. Hardcoded "Library" / - "Learn" labels until per-locale translations land — the - brand-name pattern. + :focus-within mechanic from Product. */}
  • diff --git a/apps/landing-page/app/_components/plugin-row.astro b/apps/landing-page/app/_components/plugin-row.astro index e1dac00ed..48e9ea06c 100644 --- a/apps/landing-page/app/_components/plugin-row.astro +++ b/apps/landing-page/app/_components/plugin-row.astro @@ -9,8 +9,13 @@ * forcing every callsite to write the same five-column markup twice. */ import type { SkillRecord, TemplateRecord } from '../_lib/catalog'; -import type { BundledPluginRecord } from '../_lib/bundled-plugins'; +import { + resolveBundledDescription, + resolveBundledTitle, + type BundledPluginRecord, +} from '../_lib/bundled-plugins'; import { localeFromPath, localizedHref } from '../i18n'; +import { localizeTaxonomyValue } from '../content-i18n'; interface SkillItem { kind: 'skill'; @@ -73,11 +78,18 @@ if (item.kind === 'skill') { // the row gets the diagonal-stripe placeholder and styling stays // consistent with the rest of the catalog. detailHref = item.record.detailHref; - name = item.record.title; - description = item.record.description; + name = resolveBundledTitle(item.record, locale); + description = resolveBundledDescription(item.record, locale); previewUrl = item.record.previewPoster ?? null; - modeLabel = item.record.mode; - scenarioLabel = item.record.scenario; + // Bundled-plugin records ship raw taxonomy slugs (e.g. `video`, `image`). + // Run them through the shared TAXONOMY_TERMS map so the chip rail localizes + // alongside skill/template rows instead of leaking English on every locale. + // No raw-slug fallback here: when localizeTaxonomyValue returns undefined + // (slug isn't in any translation map), we'd rather drop the chip entirely + // than surface a kebab slug like `code-migration` or `plugin-sharing` that + // reads like a debug artifact next to the localized name. + modeLabel = localizeTaxonomyValue(item.record.mode, locale); + scenarioLabel = localizeTaxonomyValue(item.record.scenario, locale); } --- diff --git a/apps/landing-page/app/_components/site-footer.astro b/apps/landing-page/app/_components/site-footer.astro index 914141b03..27ce04266 100644 --- a/apps/landing-page/app/_components/site-footer.astro +++ b/apps/landing-page/app/_components/site-footer.astro @@ -37,12 +37,12 @@ const DISCORD = 'https://discord.gg/9ptkbbqRu';

    -
    Plugins
    +
    {copy.nav.plugins}
    diff --git a/apps/landing-page/app/_lib/bundled-plugins.ts b/apps/landing-page/app/_lib/bundled-plugins.ts index b0be336d1..abc99c214 100644 --- a/apps/landing-page/app/_lib/bundled-plugins.ts +++ b/apps/landing-page/app/_lib/bundled-plugins.ts @@ -21,6 +21,11 @@ import { existsSync, readFileSync, readdirSync, statSync } from 'node:fs'; import path from 'node:path'; import { fileURLToPath } from 'node:url'; +import { + DEFAULT_LOCALE, + getLocaleDefinition, + type LandingLocaleCode, +} from '../i18n'; const SOURCE_ROOTS = [ // Build run from monorepo root. @@ -54,10 +59,19 @@ export interface BundledPluginRecord { manifestId: string; /** Source bucket. */ bucket: BundledBucket; - /** Manifest `title`. */ + /** Manifest `title` (English baseline; pre-localization fallback). */ title: string; + /** + * Manifest `title_i18n` map keyed by locale (long code, e.g. `zh-CN`, + * `zh-TW`, `pt-BR`, `ja`). Authors fill this opportunistically; consumers + * should resolve via {@link resolveBundledTitle} so the lookup chain + * (long code → short code → English fallback) stays consistent. + */ + titleI18n?: Readonly>; /** Manifest `description`. */ description: string; + /** Manifest `description_i18n` map. See {@link titleI18n} comment. */ + descriptionI18n?: Readonly>; /** Manifest `tags`. */ tags: ReadonlyArray; /** Manifest `author.name`. */ @@ -100,7 +114,9 @@ export interface BundledPluginRecord { interface BundledManifestRaw { name?: unknown; title?: unknown; + title_i18n?: unknown; description?: unknown; + description_i18n?: unknown; tags?: unknown; author?: { name?: unknown; url?: unknown }; homepage?: unknown; @@ -150,6 +166,66 @@ function asStringArray(v: unknown): ReadonlyArray { return v.filter((x): x is string => typeof x === 'string'); } +/** + * Coerce a manifest's `title_i18n` / `description_i18n` payload to a plain + * `{ [locale]: string }` map. Anything that isn't a string-valued object is + * dropped — the schema permits one of two shapes (omitted or `Record`) and we don't want a malformed manifest to poison the loader. + */ +function asLocaleMap(v: unknown): Readonly> | undefined { + if (!v || typeof v !== 'object' || Array.isArray(v)) return undefined; + const out: Record = {}; + for (const [key, value] of Object.entries(v as Record)) { + if (typeof value === 'string' && value.length > 0) out[key] = value; + } + return Object.keys(out).length > 0 ? Object.freeze(out) : undefined; +} + +/** + * Resolve a localized field from a manifest's `title_i18n` / + * `description_i18n` map. Manifest authors store keys using the long codes + * preferred by the `LocalizedText` schema (`zh-CN`, `zh-TW`, `pt-BR`, `ja`), + * while landing pages thread the short `LandingLocaleCode` (`zh`, `zh-tw`, + * `pt-br`, `ja`). The lookup chain mirrors `resolveLocalizedText` from + * `packages/contracts/src/plugins/manifest.ts`: long code → short code → + * primary language tag → English → caller-supplied fallback. + */ +function resolveLocalized( + map: Readonly> | undefined, + fallback: string, + locale: LandingLocaleCode, +): string { + if (!map) return fallback; + const def = getLocaleDefinition(locale); + const candidates = [ + def?.htmlLang, + locale, + def?.htmlLang?.split('-')[0], + 'en', + ].filter((c): c is string => Boolean(c)); + for (const candidate of candidates) { + const value = map[candidate]; + if (typeof value === 'string' && value.length > 0) return value; + } + return fallback; +} + +/** Resolve a bundled plugin's title for a given locale, falling back to English. */ +export function resolveBundledTitle( + record: BundledPluginRecord, + locale: LandingLocaleCode = DEFAULT_LOCALE, +): string { + return resolveLocalized(record.titleI18n, record.title, locale); +} + +/** Resolve a bundled plugin's description for a given locale. */ +export function resolveBundledDescription( + record: BundledPluginRecord, + locale: LandingLocaleCode = DEFAULT_LOCALE, +): string { + return resolveLocalized(record.descriptionI18n, record.description, locale); +} + function REPO_FOR_BUCKET(bucket: BundledBucket): string { return `https://github.com/nexu-io/open-design/tree/main/plugins/_official/${bucket}`; } @@ -200,7 +276,9 @@ function loadOne( const manifestId = asString(raw.name) ?? slug; const title = asString(raw.title) ?? manifestId; + const titleI18n = asLocaleMap(raw.title_i18n); const description = asString(raw.description) ?? ''; + const descriptionI18n = asLocaleMap(raw.description_i18n); // Preference order: // 1. Manifest poster URL (R2/CDN, fastest, already bandwidth-paid). @@ -220,7 +298,9 @@ function loadOne( manifestId, bucket, title, + titleI18n, description, + descriptionI18n, tags: asStringArray(raw.tags), authorName: asString(raw.author?.name), authorUrl: asString(raw.author?.url), diff --git a/apps/landing-page/app/_lib/plugins-i18n.ts b/apps/landing-page/app/_lib/plugins-i18n.ts new file mode 100644 index 000000000..9c18daa61 --- /dev/null +++ b/apps/landing-page/app/_lib/plugins-i18n.ts @@ -0,0 +1,1102 @@ +/* + * Plugins-specific i18n strings, kept separate from `_lib/i18n.ts` so + * the plugin library's chrome (hub, list pages, chip rails, share + * dialog) doesn't bloat the canonical Copy table every page already + * loads. The catch-all (`pages/[locale]/[...path].astro`) and the + * locale-prefixed detail page (`pages/[locale]/plugins/[slug]/`) + * import from here. + * + * Locale strategy: + * - English fills every key; every other locale is `Partial<...>` + * and falls back to English on miss. Translations were drafted to + * match the voice of the existing `_lib/i18n.ts` overrides for + * each locale. Long blurbs that don't have an obvious idiomatic + * translation stay in English — the catalog still reads cleanly, + * and a follow-up can polish them without rebuilding the schema. + * - 7 artifact-kind labels and 25 scene-subcategory labels are + * translated to keep the chip rails legible at a glance. + * - Share-dialog copy ports the 18-locale table from PR #2679 so + * the brand keyword "open-source Claude Design alternative" stays + * in English on every share (deliberate — see PR #2679). + */ +/* + * Locale key uses `LandingLocaleCode` (short codes — `en`, `zh`, + * `zh-tw`, `pt-br`, …) to match the rest of `app/pages/plugins/...`, + * which derives the active locale from `localeFromPath()`. The + * Cloudflare `_redirects` file maps the long-code variants + * (`/zh-CN/...` → `/zh/...`) so visitors can still land here from + * either URL shape. + */ +import type { LandingLocaleCode } from '../i18n'; +const DEFAULT_LOCALE: LandingLocaleCode = 'en'; + +export interface PluginCategoryCopy { + label: string; + description: string; +} + +export interface PluginsCopy { + hubLabel: string; + hubHeading: (n: number) => string; + hubLead: string; + + tileTemplates: string; + tileSkills: string; + tileSystems: string; + tileCraft: string; + tileTemplatesBlurb: string; + tileSkillsBlurb: string; + tileSystemsBlurb: string; + tileCraftBlurb: string; + + browseTemplates: string; + browseSkills: string; + browseSystems: string; + browseCraft: string; + + templatesLabel: string; + templatesHeading: (n: number) => string; + templatesLead: string; + + skillsLabel: string; + skillsHeading: (n: number) => string; + skillsLead: string; + + systemsLabel: string; + systemsHeading: (n: number) => string; + systemsLead: string; + + craftLabel: string; + craftHeading: (n: number) => string; + craftLead: string; + + artifactKindLabel: string; + sceneLabel: string; + allChip: string; + + category: Record< + 'prototype' | 'live-artifact' | 'deck' | 'image' | 'video' | 'hyperframes' | 'audio', + PluginCategoryCopy + >; + + subcategory: Record; + + // Detail page chrome + detailUseCta: string; // "Use this plugin →" + detailFindOnGithub: string; // "Find on GitHub →" + detailHomepage: string; // "Homepage ↗" + detailMode: string; + detailScenario: string; + detailPlatform: string; + detailSurface: string; + detailAuthor: string; + detailManifestId: string; + detailTags: string; + detailPreviewCaption: string; + detailClickForLivePreview: string; // "Click for live preview ↗" + detailOpenInNewTab: string; // "Open in new tab ↗" (visible label) + /** + * Accessible-name variant of {@link detailOpenInNewTab}: same meaning, no + * decorative `↗` glyph. Splitting the keys keeps screen readers from + * announcing the arrow as part of the control's name while the visible + * label keeps the visual cue. (Reviewer flag: `aria-label` should not + * embed decorative typography.) + */ + detailOpenInNewTabAria: string; + detailBucketLabel: Record< + 'examples' | 'image-templates' | 'video-templates' | 'scenarios' | 'design-systems' | 'atoms', + string + >; + + // A11y strings used as `aria-label` / `alt` / `