vndangkhoa/open-design
1
0
Fork 0
mirror of https://github.com/nexu-io/open-design.git synced 2026-06-01 03:14:35 +07:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: cover model option rendering (#948)

Browse source 
* test: cover model option rendering

* fix: strengthen model option regression coverage

---------

Co-authored-by: leprincep35700 <leprincep35700@users.noreply.github.com>
This commit is contained in:
leprincep35700 2026-05-08 15:38:13 +02:00 committed by GitHub
parent 2005a5b727
commit ce5f20918c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 79 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
apps/web/src/components/modelOptions.tsx
View file

@ -21,6 +21,7 @@ export function renderModelOptions(models: AgentModelOption[]) {
arr.push(m);
groups.set(provider, arr);
}
flat.sort((a, b) => (a.id === 'default' ? -1 : b.id === 'default' ? 1 : 0));
if (groups.size === 0) {
return (
<>
@ -64,7 +65,7 @@ export function isCustomModel(
modelId: string | null | undefined,
models: AgentModelOption[],
): boolean {
if (modelId == null) return false;
if (!modelId) return false;
return !models.some((m) => m.id === modelId);
}

77
apps/web/tests/components/modelOptions.test.tsx Normal file
View file

@ -0,0 +1,77 @@
import { renderToStaticMarkup } from 'react-dom/server';
import { describe, expect, it } from 'vitest';
import {
CUSTOM_MODEL_SENTINEL,
isCustomModel,
renderModelOptions,
} from '../../src/components/modelOptions';
import type { AgentModelOption } from '../../src/types';
function renderOptions(models: AgentModelOption[]): string {
return renderToStaticMarkup(<select>{renderModelOptions(models)}</select>);
}
describe('renderModelOptions', () => {
it('renders an empty model list without options', () => {
expect(renderOptions([])).toBe('<select></select>');
});
it('renders flat model lists as ungrouped options in input order', () => {
expect(
renderOptions([
{ id: 'default', label: 'Default' },
{ id: 'sonnet', label: 'Claude Sonnet' },
{ id: 'opus', label: 'Claude Opus' },
]),
).toBe(
'<select><option value="default">Default</option><option value="sonnet">Claude Sonnet</option><option value="opus">Claude Opus</option></select>',
);
});
it('pins default and other flat options before provider optgroups', () => {
expect(
renderOptions([
{ id: 'openai/gpt-5.1', label: 'openai/gpt-5.1' },
{ id: 'custom-local', label: 'Custom local' },
{ id: 'default', label: 'Default' },
{ id: 'anthropic/claude-sonnet-4.5', label: 'anthropic/claude-sonnet-4.5' },
{ id: 'openai/o3', label: 'openai/o3' },
]),
).toBe(
'<select><option value="default">Default</option><option value="custom-local">Custom local</option><optgroup label="openai"><option value="openai/gpt-5.1">gpt-5.1</option><option value="openai/o3">o3</option></optgroup><optgroup label="anthropic"><option value="anthropic/claude-sonnet-4.5">claude-sonnet-4.5</option></optgroup></select>',
);
});
it('treats leading-slash ids as flat and only strips matching provider label prefixes', () => {
expect(
renderOptions([
{ id: '/missing-provider', label: '/missing-provider' },
{ id: 'openai/gpt-5.1', label: 'GPT 5.1' },
{ id: 'openai/o3', label: 'openai/o3' },
]),
).toBe(
'<select><option value="/missing-provider">/missing-provider</option><optgroup label="openai"><option value="openai/gpt-5.1">GPT 5.1</option><option value="openai/o3">o3</option></optgroup></select>',
);
});
});
describe('isCustomModel', () => {
const models: AgentModelOption[] = [
{ id: 'default', label: 'Default' },
{ id: 'openai/gpt-5.1', label: 'openai/gpt-5.1' },
];
it('returns false for empty selections and listed model ids', () => {
expect(isCustomModel(null, models)).toBe(false);
expect(isCustomModel(undefined, models)).toBe(false);
expect(isCustomModel('', models)).toBe(false);
expect(isCustomModel('default', models)).toBe(false);
expect(isCustomModel('openai/gpt-5.1', models)).toBe(false);
});
it('returns true for unlisted custom ids and the custom sentinel', () => {
expect(isCustomModel('local/my-model', models)).toBe(true);
expect(isCustomModel(CUSTOM_MODEL_SENTINEL, models)).toBe(true);
});
});