vndangkhoa/neko
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: ensure webrtc close is executed only once.

Browse source
This commit is contained in:
Miroslav Šedivý 2023-03-27 19:28:28 +02:00
parent 08a5d5abb4
commit 2ff47ac920
1 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
internal/webrtc/manager.go
View file

@ -4,6 +4,7 @@ import (
"fmt" "fmt"
"net" "net"
"strings" "strings"
"sync"
"sync/atomic" "sync/atomic"
"time" "time"
@ -567,6 +568,7 @@ func (manager *WebRTCManagerCtx) CreatePeer(session types.Session, bitrate int,
logger.Info().Interface("data_channel", dc).Msg("got remote data channel") logger.Info().Interface("data_channel", dc).Msg("got remote data channel")
}) })
var once sync.Once
connection.OnConnectionStateChange(func(state webrtc.PeerConnectionState) { connection.OnConnectionStateChange(func(state webrtc.PeerConnectionState) {
switch state { switch state {
case webrtc.PeerConnectionStateConnected: case webrtc.PeerConnectionStateConnected:
@ -575,6 +577,8 @@ func (manager *WebRTCManagerCtx) CreatePeer(session types.Session, bitrate int,
webrtc.PeerConnectionStateFailed: webrtc.PeerConnectionStateFailed:
connection.Close() connection.Close()
case webrtc.PeerConnectionStateClosed: case webrtc.PeerConnectionStateClosed:
// ensure we only run this once
once.Do(func() {
session.SetWebRTCConnected(peer, false) session.SetWebRTCConnected(peer, false)
if err = video.RemoveReceiver(videoTrack); err != nil { if err = video.RemoveReceiver(videoTrack); err != nil {
logger.Err(err).Msg("failed to remove video receiver") logger.Err(err).Msg("failed to remove video receiver")
@ -582,6 +586,7 @@ func (manager *WebRTCManagerCtx) CreatePeer(session types.Session, bitrate int,
audioTrack.Shutdown() audioTrack.Shutdown()
videoTrack.Shutdown() videoTrack.Shutdown()
close(videoRtcp) close(videoRtcp)
})
} }
manager.metrics.SetState(session, state) manager.metrics.SetState(session, state)