From 8f9e201496295e3e159bc23e93ff577acc84592d Mon Sep 17 00:00:00 2001
From: BlackSigKill <blacksigkill@gmail.com>
Date: Fri, 13 Feb 2026 17:27:20 +0100
Subject: [PATCH] refacto : clarity and selector consistency

---
 public/login.html        | 24 ++++++++++++------------
 vite-plugin-auth-gate.js |  1 +
 2 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/public/login.html b/public/login.html
index ecd40f7..94b9456 100644
--- a/public/login.html
+++ b/public/login.html
@@ -205,7 +205,7 @@
                 Sign in with Google
             </button>
 
-            <div class="divider" style="display:none">or</div>
+            <div id="divider" class="divider" style="display:none">or</div>
 
             <form id="email-form" onsubmit="emailAuth(event)" style="display:none">
                 <div class="form-group">
@@ -277,9 +277,19 @@
             const auth = getAuth(fbApp);
             const provider = new GoogleAuthProvider();
 
+            function showError(msg) {
+                const el = document.getElementById('error');
+                el.textContent = msg;
+                el.style.display = 'block';
+            }
+
+            function hideError() {
+                document.getElementById('error').style.display = 'none';
+            }
+
             const googleBtn = document.getElementById('google-btn');
             const emailForm = document.getElementById('email-form');
-            const divider = document.querySelector('.divider');
+            const divider = document.getElementById('divider');
             const providerState = {
                 google: true,
                 password: true,
@@ -307,16 +317,6 @@
 
             renderProviders();
 
-            function showError(msg) {
-                const el = document.getElementById('error');
-                el.textContent = msg;
-                el.style.display = 'block';
-            }
-
-            function hideError() {
-                document.getElementById('error').style.display = 'none';
-            }
-
             function setLoading(loading) {
                 document.getElementById('google-btn').disabled = loading;
                 document.getElementById('email-btn').disabled = loading;
diff --git a/vite-plugin-auth-gate.js b/vite-plugin-auth-gate.js
index b5a4c2f..68a6e17 100644
--- a/vite-plugin-auth-gate.js
+++ b/vite-plugin-auth-gate.js
@@ -58,6 +58,7 @@ export default function authGatePlugin() {
                 authProviderOverrides.google = AUTH_GOOGLE_ENABLED !== 'false';
             }
             if (AUTH_EMAIL_ENABLED !== undefined) {
+                // Firebase calls it "password" provider; env uses "EMAIL" for clarity
                 authProviderOverrides.password = AUTH_EMAIL_ENABLED !== 'false';
             }
             if (Object.keys(authProviderOverrides).length > 0) {