From 2c0ca538d11306fcc2968fe313ce67b76b193221 Mon Sep 17 00:00:00 2001 From: SamidyFR <168582143+SamidyFR@users.noreply.github.com> Date: Tue, 13 Jan 2026 20:26:13 +0000 Subject: [PATCH] style: auto-fix linting issues --- index.html | 38 ++++++++++++++++---- js/app.js | 17 ++++++--- js/metadata.js | 95 +++++++++++++++++++++++++++++--------------------- js/ui.js | 4 +-- 4 files changed, 100 insertions(+), 54 deletions(-) diff --git a/index.html b/index.html index cee8c71..1830664 100644 --- a/index.html +++ b/index.html @@ -658,21 +658,45 @@
-
+
-

- Select a folder on your device to play local files.
+

+ Select a folder on your device to play local files.
Note: Metadata reading is basic (FLAC/MP3 tags).

- diff --git a/js/app.js b/js/app.js index f6d1d60..36acdc2 100644 --- a/js/app.js +++ b/js/app.js @@ -824,7 +824,7 @@ document.addEventListener('DOMContentLoaded', async () => { try { const handle = await window.showDirectoryPicker({ id: 'music-folder', - mode: 'read' + mode: 'read', }); await db.saveSetting('local_folder_handle', handle); @@ -832,7 +832,8 @@ document.addEventListener('DOMContentLoaded', async () => { const btn = document.getElementById('select-local-folder-btn'); const btnText = document.getElementById('select-local-folder-text'); if (btn) { - if (btnText) btnText.textContent = 'Scanning...'; else btn.textContent = 'Scanning...'; + if (btnText) btnText.textContent = 'Scanning...'; + else btn.textContent = 'Scanning...'; btn.disabled = true; } @@ -843,7 +844,13 @@ document.addEventListener('DOMContentLoaded', async () => { for await (const entry of dirHandle.values()) { if (entry.kind === 'file') { const name = entry.name.toLowerCase(); - if (name.endsWith('.flac') || name.endsWith('.mp3') || name.endsWith('.m4a') || name.endsWith('.wav') || name.endsWith('.ogg')) { + if ( + name.endsWith('.flac') || + name.endsWith('.mp3') || + name.endsWith('.m4a') || + name.endsWith('.wav') || + name.endsWith('.ogg') + ) { const file = await entry.getFile(); const metadata = await readTrackMetadata(file); metadata.id = `local-${idCounter++}-${file.name}`; @@ -865,7 +872,6 @@ document.addEventListener('DOMContentLoaded', async () => { window.localFilesCache = tracks; ui.renderLibraryPage(); - } catch (err) { if (err.name !== 'AbortError') { console.error('Error selecting folder:', err); @@ -874,7 +880,8 @@ document.addEventListener('DOMContentLoaded', async () => { const btn = document.getElementById('select-local-folder-btn'); const btnText = document.getElementById('select-local-folder-text'); if (btn) { - if (btnText) btnText.textContent = 'Select Music Folder'; else btn.textContent = 'Select Music Folder'; + if (btnText) btnText.textContent = 'Select Music Folder'; + else btn.textContent = 'Select Music Folder'; btn.disabled = false; } } diff --git a/js/metadata.js b/js/metadata.js index 4524d35..b0ec131 100644 --- a/js/metadata.js +++ b/js/metadata.js @@ -33,14 +33,14 @@ export async function addMetadataToAudio(audioBlob, track, api, quality) { */ export async function readTrackMetadata(file) { const metadata = { - title: file.name.replace(/\.[^/.]+$/, ""), + title: file.name.replace(/\.[^/.]+$/, ''), artists: [], artist: { name: 'Unknown Artist' }, // For fallback/compatibility album: { title: 'Unknown Album', cover: 'assets/appicon.png', releaseDate: null }, duration: 0, isLocal: true, file: file, - id: `local-${file.name}-${file.lastModified}` + id: `local-${file.name}-${file.lastModified}`, }; try { @@ -69,8 +69,8 @@ async function readFlacMetadata(file, metadata) { if (!isFlacFile(dataView)) return; const blocks = parseFlacBlocks(dataView); - const vorbisBlock = blocks.find(b => b.type === 4); - + const vorbisBlock = blocks.find((b) => b.type === 4); + const artists = []; if (vorbisBlock) { const offset = vorbisBlock.offset; @@ -100,7 +100,7 @@ async function readFlacMetadata(file, metadata) { } if (artists.length > 0) { - metadata.artists = artists.flatMap(a => a.split(/; |\/|\\/)).map(name => ({ name: name.trim() })); + metadata.artists = artists.flatMap((a) => a.split(/; |\/|\\/)).map((name) => ({ name: name.trim() })); } } @@ -109,67 +109,67 @@ async function readM4aMetadata(file, metadata) { const chunkSize = Math.min(file.size, 5 * 1024 * 1024); const buffer = await file.slice(0, chunkSize).arrayBuffer(); const view = new DataView(buffer); - + const atoms = parseMp4Atoms(view); - - const moov = atoms.find(a => a.type === 'moov'); + const moov = atoms.find((a) => a.type === 'moov'); if (!moov) return; - + const moovStart = moov.offset + 8; const moovLen = moov.size - 8; const moovData = new DataView(view.buffer, moovStart, moovLen); const moovAtoms = parseMp4Atoms(moovData); - - const udta = moovAtoms.find(a => a.type === 'udta'); + + const udta = moovAtoms.find((a) => a.type === 'udta'); if (!udta) return; - + const udtaStart = moovStart + udta.offset + 8; const udtaLen = udta.size - 8; const udtaData = new DataView(view.buffer, udtaStart, udtaLen); const udtaAtoms = parseMp4Atoms(udtaData); - - const meta = udtaAtoms.find(a => a.type === 'meta'); + + const meta = udtaAtoms.find((a) => a.type === 'meta'); if (!meta) return; - + const metaStart = udtaStart + meta.offset + 12; const metaLen = meta.size - 12; const metaData = new DataView(view.buffer, metaStart, metaLen); const metaAtoms = parseMp4Atoms(metaData); - - const ilst = metaAtoms.find(a => a.type === 'ilst'); + + const ilst = metaAtoms.find((a) => a.type === 'ilst'); if (!ilst) return; - + const ilstStart = metaStart + ilst.offset + 8; const ilstLen = ilst.size - 8; const ilstData = new DataView(view.buffer, ilstStart, ilstLen); const items = parseMp4Atoms(ilstData); - + let artistStr = null; - + for (const item of items) { const itemStart = ilstStart + item.offset + 8; const itemLen = item.size - 8; const itemData = new DataView(view.buffer, itemStart, itemLen); - const dataAtom = parseMp4Atoms(itemData).find(a => a.type === 'data'); + const dataAtom = parseMp4Atoms(itemData).find((a) => a.type === 'data'); if (dataAtom) { const contentLen = dataAtom.size - 16; const contentOffset = itemStart + dataAtom.offset + 16; - + if (item.type === '©nam') { metadata.title = new TextDecoder().decode(new Uint8Array(view.buffer, contentOffset, contentLen)); } else if (item.type === '©ART') { artistStr = new TextDecoder().decode(new Uint8Array(view.buffer, contentOffset, contentLen)); } else if (item.type === '©alb') { - metadata.album.title = new TextDecoder().decode(new Uint8Array(view.buffer, contentOffset, contentLen)); + metadata.album.title = new TextDecoder().decode( + new Uint8Array(view.buffer, contentOffset, contentLen) + ); } } } if (artistStr) { - metadata.artists = artistStr.split(/; |\/|\\/).map(name => ({ name: name.trim() })); + metadata.artists = artistStr.split(/; |\/|\\/).map((name) => ({ name: name.trim() })); } - } catch (e) { console.warn('Error parsing M4A:', e); } @@ -183,10 +183,10 @@ async function readMp3Metadata(file, metadata) { const majorVer = view.getUint8(3); const size = readSynchsafeInteger32(view, 6); const tagSize = size + 10; - + buffer = await file.slice(0, tagSize).arrayBuffer(); view = new DataView(buffer); - + let offset = 10; if ((view.getUint8(5) & 0x40) !== 0) { const extSize = readSynchsafeInteger32(view, offset); @@ -197,7 +197,7 @@ async function readMp3Metadata(file, metadata) { let tpe2 = null; while (offset < view.byteLength) { let frameId, frameSize; - + if (majorVer === 3) { frameId = new TextDecoder().decode(new Uint8Array(buffer, offset, 4)); frameSize = view.getUint32(offset + 4, false); @@ -210,7 +210,7 @@ async function readMp3Metadata(file, metadata) { break; } - if (frameId.charCodeAt(0) === 0) break; + if (frameId.charCodeAt(0) === 0) break; if (offset + frameSize > view.byteLength) break; const frameData = new DataView(buffer, offset, frameSize); @@ -228,18 +228,27 @@ async function readMp3Metadata(file, metadata) { const artistStr = tpe1 || tpe2; if (artistStr) { - metadata.artists = artistStr.split('/').map(name => ({ name: name.trim() })); + metadata.artists = artistStr.split('/').map((name) => ({ name: name.trim() })); } } - + if (file.size > 128) { const tailBuffer = await file.slice(file.size - 128).arrayBuffer(); const tailView = new DataView(tailBuffer); const tag = new TextDecoder().decode(new Uint8Array(tailBuffer, 0, 3)); if (tag === 'TAG') { - const title = new TextDecoder().decode(new Uint8Array(tailBuffer, 3, 30)).replace(/\0/g, '').trim(); - const artist = new TextDecoder().decode(new Uint8Array(tailBuffer, 33, 30)).replace(/\0/g, '').trim(); - const album = new TextDecoder().decode(new Uint8Array(tailBuffer, 63, 30)).replace(/\0/g, '').trim(); + const title = new TextDecoder() + .decode(new Uint8Array(tailBuffer, 3, 30)) + .replace(/\0/g, '') + .trim(); + const artist = new TextDecoder() + .decode(new Uint8Array(tailBuffer, 33, 30)) + .replace(/\0/g, '') + .trim(); + const album = new TextDecoder() + .decode(new Uint8Array(tailBuffer, 63, 30)) + .replace(/\0/g, '') + .trim(); if (title) metadata.title = title; if (artist && metadata.artists.length === 0) { metadata.artists = [{ name: artist }]; @@ -266,26 +275,32 @@ function readID3Text(view) { else if (encoding === 1) decoder = new TextDecoder('utf-16'); else if (encoding === 2) decoder = new TextDecoder('utf-16be'); else decoder = new TextDecoder('utf-8'); - + return decoder.decode(buffer).replace(/\0/g, ''); } function readID3Picture(view) { let offset = 1; const encoding = view.getUint8(0); - + let mimeEnd = offset; while (view.getUint8(mimeEnd) !== 0) mimeEnd++; - const mime = new TextDecoder('iso-8859-1').decode(view.buffer.slice(view.byteOffset + offset, view.byteOffset + mimeEnd)); + const mime = new TextDecoder('iso-8859-1').decode( + view.buffer.slice(view.byteOffset + offset, view.byteOffset + mimeEnd) + ); offset = mimeEnd + 1; - + const picType = view.getUint8(offset); offset++; let descEnd = offset; - while (view.getUint8(descEnd) !== 0 || (encoding === 1 || encoding === 2 ? view.getUint8(descEnd+1) !== 0 : false)) descEnd++; + while ( + view.getUint8(descEnd) !== 0 || + (encoding === 1 || encoding === 2 ? view.getUint8(descEnd + 1) !== 0 : false) + ) + descEnd++; offset = descEnd + (encoding === 1 || encoding === 2 ? 2 : 1); - + const imgData = view.buffer.slice(view.byteOffset + offset, view.byteOffset + view.byteLength); const blob = new Blob([imgData], { type: mime }); return URL.createObjectURL(blob); diff --git a/js/ui.js b/js/ui.js index a2b1acb..a1fe44a 100644 --- a/js/ui.js +++ b/js/ui.js @@ -793,7 +793,7 @@ export class UIRenderer { async renderLocalFiles(container) { if (!container) return; - + const introDiv = document.getElementById('local-files-intro'); const headerDiv = document.getElementById('local-files-header'); const listContainer = document.getElementById('local-files-list'); @@ -802,7 +802,7 @@ export class UIRenderer { const handle = await db.getSetting('local_folder_handle'); if (handle) { if (selectBtnText) selectBtnText.textContent = `Load "${handle.name}"`; - + if (window.localFilesCache && window.localFilesCache.length > 0) { if (introDiv) introDiv.style.display = 'none'; if (headerDiv) {