refactor: conditionally show lyrics settings only when embed lyrics is enabled

This commit is contained in:
zarzet 2026-02-17 20:56:34 +07:00
parent 537bab69ab
commit 813ed79073

View file

@ -306,20 +306,19 @@ class _DownloadSettingsPageState extends ConsumerState<DownloadSettingsPage> {
onChanged: (value) => ref
.read(settingsProvider.notifier)
.setEmbedLyrics(value),
showDivider: settings.embedLyrics,
),
if (settings.embedLyrics) ...[
SettingsItem(
icon: Icons.lyrics_outlined,
title: context.l10n.lyricsMode,
subtitle: settings.embedLyrics
? _getLyricsModeLabel(context, settings.lyricsMode)
: context.l10n.extensionsDisabled,
onTap: settings.embedLyrics
? () => _showLyricsModePicker(
subtitle:
_getLyricsModeLabel(context, settings.lyricsMode),
onTap: () => _showLyricsModePicker(
context,
ref,
settings.lyricsMode,
)
: null,
),
),
SettingsItem(
icon: Icons.source_outlined,
@ -381,6 +380,7 @@ class _DownloadSettingsPageState extends ConsumerState<DownloadSettingsPage> {
showDivider: false,
),
],
],
),
),